feat(pegasus): implement correct result and denom trace handling #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig-4614-ics20-trace-and-result
branch
from
2da21c0 to
f1801f6
Compare
dckc
approved these changes
Feb 20, 2022
michaelfig
added
the
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4614
refs: cosmos/ibc#661
Description
Implement IBC denom trace transforms for Pegasus, as well as use the acknowledgement packet's actual
resultanderrorproperties instead ofsuccess.Security Considerations
The incorrect parsing of acknowledgement packets caused refunds to be given even though the transfer went through. This led to a practically infinite supply of tokens on Pegasus connections to other chains.
Documentation Considerations
Testing Considerations