-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap core: refactor, diagnostics, chain support #4387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
bootstrap-core
branch
from
January 26, 2022 01:27
e019364
to
de72509
Compare
probably crashes in sim-chain mode
- factor out registerNetworkProtocols - factor out makeChainBundler - add vatParameters arg - import types for vats - avoid casting result of buildZoe - turn bootMsg example comment into machine-checked type - default attMakerFor to non-bridge case rather than undefined - fix array arg to buildDistributor - factor out createLocalBundle - add vatPowers arg - refactor: unroll setupCommandDevice - feat: don't await vatAdminSvc I can't imagine any need for it to be local. - docs: prune refs to python provisioning service Is there anything left that's worth saying about "scenario #1"? - docs: declare type of makeFeeCollector move function comment into JSDoc
some styling issues remain - toward authorityViz: read bootstrapManifest - feat: visualize vatPowers - feat: authority viz with distinctive styles with --sim-chain option
- chore(vats): clean up debug logging - fix(vats): buildZoe was missing permit for nameAdmins - refactor: hoist wellKnownERights
- factor out startTimerService - factor out bootEconomy.js - reserve installations, instances as well as issuers, brands in agoricNames
- moar attestation pruning
- prune logging
Connecting vattp / mailbox is more part of the SwingSet API.
Note conflict around OptionalBridgeManager.
michaelfig
force-pushed
the
bootstrap-core
branch
from
January 26, 2022 03:04
267feb0
to
ce94710
Compare
michaelfig
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm willing to accept responsibility. :)
michaelfig
added
the
automerge:no-update
(expert!) Automatically merge without updates
label
Jan 26, 2022
mhofman
added a commit
to Agoric/testnet-load-generator
that referenced
this pull request
Feb 4, 2022
Fix for BLD removed as collateral in Bootstrap change Agoric/agoric-sdk#4387
mhofman
added a commit
to Agoric/testnet-load-generator
that referenced
this pull request
Feb 4, 2022
Fix for BLD removed as collateral in Bootstrap change Agoric/agoric-sdk#4387
mhofman
added a commit
to Agoric/testnet-load-generator
that referenced
this pull request
Feb 5, 2022
Use USDC for compatibility with newer SDKs Fix for BLD removed as collateral in Bootstrap change Agoric/agoric-sdk#4387
mhofman
added a commit
to Agoric/testnet-load-generator
that referenced
this pull request
Feb 5, 2022
Use USDC for compatibility with newer SDKs Fix for BLD removed as collateral in Bootstrap change Agoric/agoric-sdk#4387
mhofman
added a commit
to Agoric/testnet-load-generator
that referenced
this pull request
Feb 5, 2022
Use USDC for compatibility with newer SDKs Fix for BLD removed as collateral in Bootstrap change Agoric/agoric-sdk#4387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #4165
@agoric/vats/decentral-demo-config.json