Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove POC Zoe fee purse, expiry, etc #4225

Merged
merged 8 commits into from
Dec 29, 2021
Merged

Remove POC Zoe fee purse, expiry, etc #4225

merged 8 commits into from
Dec 29, 2021

Conversation

erights
Copy link
Member

@erights erights commented Dec 29, 2021

Stacked on #4222 but probably best reviewed directly against master.

@erights erights self-assigned this Dec 29, 2021
@erights erights mentioned this pull request Dec 29, 2021
Closed
@erights erights changed the base branch from master to markm-remove-zoe-metering December 29, 2021 02:54
@erights erights marked this pull request as ready for review December 29, 2021 04:08
@erights erights changed the title WIP Remove Zoe fee purse, expiry, etc Remove Zoe fee purse, expiry, etc Dec 29, 2021
Chris-Hibbert
Chris-Hibbert requested changes Dec 29, 2021
View reviewed changes
packages/treasury/src/stablecoinMachine.js Outdated Show resolved Hide resolved
packages/treasury/test/faucet.js Outdated Show resolved Hide resolved
packages/vats/src/bootstrap.js Outdated Show resolved Hide resolved
packages/zoe/src/zoeService/zoe.js Show resolved Hide resolved
packages/zoe/src/contracts/vpool-xyk-amm/swap.js Outdated Show resolved Hide resolved
packages/zoe/src/contracts/vpool-xyk-amm/swap.js Outdated Show resolved Hide resolved
packages/zoe/src/zoeService/types.js Show resolved Hide resolved
packages/zoe/test/unitTests/zcf/test-zcfSeat-exit.js Outdated Show resolved Hide resolved
@erights erights changed the base branch from markm-remove-zoe-metering to master December 29, 2021 19:08
@erights erights changed the title Remove Zoe fee purse, expiry, etc Remove POC Zoe fee purse, expiry, etc Dec 29, 2021
Chris-Hibbert
Chris-Hibbert approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! thanks.

@erights erights added the automerge:squash Automatically squash merge label Dec 29, 2021
@mergify mergify bot merged commit 3c4b2fb into master Dec 29, 2021
@mergify mergify bot deleted the markm-remove-zoe-feePurse branch December 29, 2021 23:31
@erights erights mentioned this pull request Dec 30, 2021
Closed
@dckc dckc added the metering charging for execution (was: package: tame-metering and transform-metering) label Dec 30, 2021
dckc added a commit to Agoric/dapp-fungible-faucet that referenced this pull request May 5, 2022
@dckc
prune call to obsolete getFeePurse
53afdb1 
`getFeePurse` is not in the agoric sdk since Agoric/agoric-sdk#4225
@dckc dckc mentioned this pull request May 5, 2022
Merged
dckc added a commit to Agoric/dapp-fungible-faucet that referenced this pull request May 14, 2022
@dckc
fix: prune call to obsolete getFeePurse (#45)
30d48e0 
* prune call to obsolete getFeePurse

`getFeePurse` is not in the agoric sdk since Agoric/agoric-sdk#4225

* style: prune unused names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris-Hibbert Chris-Hibbert Chris-Hibbert approved these changes

@dckc dckc Awaiting requested review from dckc

@warner warner Awaiting requested review from warner

Assignees

@erights erights

Labels
automerge:squash Automatically squash merge metering charging for execution (was: package: tame-metering and transform-metering)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erights @Chris-Hibbert @dckc