Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for want patterns #4217

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Prepare for want patterns #4217

merged 2 commits into from
Jan 7, 2022

Conversation

erights
Copy link
Member

@erights erights commented Dec 27, 2021

No description provided.

@erights erights force-pushed the markm-use-want-patterns branch from 7aaccfd to 86363be Compare December 27, 2021 05:41
@erights erights mentioned this pull request Dec 28, 2021
Closed
@erights erights force-pushed the markm-zoe-use-patterns branch from 5c0dc2f to ef116ca Compare December 28, 2021 04:00
@erights erights force-pushed the markm-use-want-patterns branch 2 times, most recently from f458795 to 005ccaf Compare December 28, 2021 04:21
@erights erights requested a review from FUDCo December 28, 2021 05:45
@erights erights force-pushed the markm-zoe-use-patterns branch from 9c41def to 3426463 Compare December 30, 2021 00:57
@erights erights force-pushed the markm-use-want-patterns branch from c6197bc to a69c6d6 Compare December 30, 2021 00:59
@erights erights force-pushed the markm-zoe-use-patterns branch from 3426463 to 72ef843 Compare December 30, 2021 01:50
@erights erights force-pushed the markm-use-want-patterns branch from a69c6d6 to 884e751 Compare December 30, 2021 20:05
FUDCo
FUDCo approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, though might also want to run it past somebody with more domain-specific paranoia.

@erights erights force-pushed the markm-zoe-use-patterns branch from b3daf7a to 42e8678 Compare January 3, 2022 22:27
@erights erights force-pushed the markm-use-want-patterns branch from 4716027 to 0147b2a Compare January 3, 2022 22:30
@erights erights force-pushed the markm-zoe-use-patterns branch from 42e8678 to ea711bd Compare January 3, 2022 23:54
@erights erights requested a review from Chris-Hibbert January 4, 2022 00:27
@erights
Copy link
Member Author

erights commented Jan 4, 2022

Hi @Chris-Hibbert , we need your eyeballs again ;). Thanks.

Base automatically changed from markm-zoe-use-patterns to master January 4, 2022 00:33
@erights erights force-pushed the markm-use-want-patterns branch from 0147b2a to b0af0f1 Compare January 4, 2022 01:35
Chris-Hibbert
Chris-Hibbert reviewed Jan 4, 2022
View reviewed changes
Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me modulo

  • I don't have enough context to evaluate the changes to patternMathers.js
  • coerceAmountPatternKeywordRecord() allows amounts that are patterns, but there don't seem to be tests of this path. Is this premature?

packages/zoe/src/instanceRecordStorage.js Show resolved Hide resolved
packages/zoe/test/unitTests/test-cleanProposal.js Outdated Show resolved Hide resolved
packages/zoe/src/cleanProposal.js Show resolved Hide resolved
@erights erights force-pushed the markm-use-want-patterns branch from b0af0f1 to fecfaee Compare January 6, 2022 22:20
@erights erights force-pushed the markm-use-want-patterns branch from fecfaee to 2fe8e42 Compare January 6, 2022 22:43
@erights erights added the automerge:squash Automatically squash merge label Jan 7, 2022
@mergify mergify bot merged commit 1ad7b2e into master Jan 7, 2022
@mergify mergify bot deleted the markm-use-want-patterns branch January 7, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris-Hibbert Chris-Hibbert Chris-Hibbert left review comments

@FUDCo FUDCo FUDCo approved these changes

Assignees
No one assigned
Labels
automerge:squash Automatically squash merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erights @FUDCo @Chris-Hibbert