-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: represent storage in same order in genesis state #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this!
michaelfig
added
the
automerge:no-update
(expert!) Automatically merge without updates
label
Dec 2, 2021
This was referenced Oct 21, 2022
This was referenced Oct 21, 2022
This was referenced Oct 21, 2022
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#122
Open
This was referenced Oct 21, 2022
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#126
Open
This was referenced Oct 22, 2022
This was referenced Oct 22, 2022
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#138
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#139
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#141
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#142
Open
This was referenced Feb 2, 2024
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#253
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#255
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#257
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#259
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#260
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#261
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#262
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#263
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge:no-update
(expert!) Automatically merge without updates
cosmic-swingset
package: cosmic-swingset
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #4134
Description
Similar to #4137, make the order of storage entries deterministic in the swingset genesis state.
This has no effect on operation of the chain, but should make it easier to compare different genesis states created by different nodes.
Security Considerations
None.
Documentation Considerations
N/A
Testing Considerations
N/A