fix(xsnap): format objects nicely in console using SES assert.quote #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
reviewed
Sep 20, 2021
packages/xsnap/lib/console-shim.js
Outdated
| print(` ${i}:`, a.toString ? a.toString() : '<no .toString>', typeof a); | ||
| }); | ||
| } | ||
| // eslint-disable-next-line |
There was a problem hiding this comment.
eslint doesn't know that xsnap has globalThis.print.
There was a problem hiding this comment.
no-undef was not enough somehow.
note the eslint-disable-next-line was there before this change. twice three times, in fact.
There was a problem hiding this comment.
Please add a comment explaining this, so it won't look so mysterious to the next reader.
There was a problem hiding this comment.
/* global print */ also works, and TSC interprets it as print : any.
erights
approved these changes
Sep 20, 2021
packages/xsnap/lib/console-shim.js
Outdated
| print(` ${i}:`, a.toString ? a.toString() : '<no .toString>', typeof a); | ||
| }); | ||
| } | ||
| // eslint-disable-next-line |
There was a problem hiding this comment.
Please add a comment explaining this, so it won't look so mysterious to the next reader.
dckc
force-pushed
the
3844-xsnap-console-fmt
branch
2 times, most recently
from
5ad8e36 to
1da421f
Compare
Co-authored-by: Mark S. Miller <[email protected]>
dckc
force-pushed
the
3844-xsnap-console-fmt
branch
from
1da421f to
291f914
Compare
dckc
force-pushed
the
3844-xsnap-console-fmt
branch
from
291f914 to
bd937b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3844
A couple things are a little awkward but seem cost-effective:
setQuote()to break the cycle where SES requiresconsoleandconsoleis implemented usingassert.quotefrom SES.print().