Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renovate timer services #3853

Merged
merged 6 commits into from
Sep 20, 2021
Merged

Renovate timer services #3853

merged 6 commits into from
Sep 20, 2021

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented Sep 19, 2021 •
edited
Loading

In this PR:

Still needs:

  • tests
  • documentation repo updates to reflect the changes

@michaelfig michaelfig self-assigned this Sep 19, 2021
erights
erights reviewed Sep 19, 2021
View reviewed changes
Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the changes to notifier. Let's zoom sometime.

Be aware of https://github.com/Agoric/agoric-sdk/blob/master/packages/notifier/README.md

I haven't looked at it in a while. If we do go ahead with this change, please check if that doc needs to be updated.

packages/SwingSet/src/vats/vat-timerWrapper.js Outdated Show resolved Hide resolved
@michaelfig michaelfig requested review from erights and removed request for erights September 20, 2021 02:10
@michaelfig michaelfig force-pushed the mfig-timer-renovation branch from 4e62c2b to fb2c4a3 Compare September 20, 2021 02:17
@michaelfig
Copy link
Member Author

michaelfig commented Sep 20, 2021 •
edited
Loading

I don't understand the changes to notifier.

In the interest of decoupling this optimisation from the more urgent changes needed to solve the issues at hand, I've moved the notifier changes and the reliance on them to a new PR #3854.

@michaelfig michaelfig marked this pull request as ready for review September 20, 2021 02:52
@michaelfig michaelfig force-pushed the mfig-timer-renovation branch from fb2c4a3 to f505504 Compare September 20, 2021 02:54
@michaelfig michaelfig force-pushed the mfig-timer-renovation branch from f505504 to 7a2c830 Compare September 20, 2021 03:40
@erights
Copy link
Member

erights commented Sep 20, 2021

I don't understand the changes to notifier.

In the interest of decoupling this optimisation from the more urgent changes needed to solve the issues at hand, I've moved the notifier changes and the reliance on them to a new PR #3854.

Excellent, thanks!

@erights
Copy link
Member

erights commented Sep 20, 2021

With that gone, would you mind if I unlisted myself as a reviewer of this PR?

@michaelfig
Copy link
Member Author

With that gone, would you mind if I unlisted myself as a reviewer of this PR?

Go right ahead! (I couldn't figure out how to do that, but I tried.)

@erights erights requested review from erights and removed request for erights September 20, 2021 16:49
Chris-Hibbert
Chris-Hibbert requested changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

packages/SwingSet/docs/timer.md Outdated
Comment on lines 44 to 45
Then users in the REPL can use the `localTimerService` or `chainTimerService`
(both in seconds) to schedule wakeups.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems inconsistent with the above. Is localTimerService in seconds or milliseconds?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used to be seconds (but was incorrect). Now I've moved to milliseconds and corrected the polling to be accurate.

packages/SwingSet/docs/timer.md Show resolved Hide resolved
packages/SwingSet/src/vats/vat-timerWrapper.js Outdated
Comment on lines 29 to 32
createRepeater(delay, interval) {
delay = Nat(delay);
interval = Nat(interval);
return timerService.makeRepeater(delay, interval);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good opportunity to get rid of the deprecated createRepeater(). It's only used in one test in agoric-sdk. I doubt it's used outside this repo.

packages/zoe/tools/manualTimer.js Show resolved Hide resolved
@michaelfig michaelfig force-pushed the mfig-timer-renovation branch from dda819b to 3654717 Compare September 20, 2021 18:37
@michaelfig michaelfig mentioned this pull request Sep 20, 2021
Merged
Chris-Hibbert
Chris-Hibbert approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@michaelfig michaelfig merged commit 99d66bf into master Sep 20, 2021
@michaelfig michaelfig deleted the mfig-timer-renovation branch September 20, 2021 20:33
@Chris-Hibbert Chris-Hibbert mentioned this pull request Sep 29, 2021
Closed
@Kashuhackerone Kashuhackerone mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erights erights erights left review comments

@Chris-Hibbert Chris-Hibbert Chris-Hibbert approved these changes

Assignees

@michaelfig michaelfig

Labels
notifier
Projects
None yet
Milestone
No milestone
3 participants
@michaelfig @erights @Chris-Hibbert