Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(agoric): Convert RESM to NESM #3635

Merged
merged 2 commits into from
Aug 13, 2021
Merged

refactor(agoric): Convert RESM to NESM #3635

merged 2 commits into from
Aug 13, 2021

Conversation

kriskowal
Copy link
Member

This changes the agoric-cli package to use Node.js ESM instead of -r esm emulation.

Refs #527

@kriskowal kriskowal requested a review from michaelfig August 10, 2021 03:13
@kriskowal kriskowal force-pushed the 527-agoric branch 3 times, most recently from d890b7c to 2690f6c Compare August 11, 2021 04:22
@kriskowal kriskowal changed the base branch from 527-governance to 527-ui-components August 11, 2021 21:35
@kriskowal kriskowal marked this pull request as draft August 11, 2021 21:36
@kriskowal kriskowal force-pushed the 527-agoric branch 2 times, most recently from 05dec34 to c128645 Compare August 11, 2021 22:09
Base automatically changed from 527-ui-components to master August 12, 2021 01:25
@kriskowal kriskowal marked this pull request as ready for review August 12, 2021 21:54
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Glad to see this!

@kriskowal kriskowal merged commit 99d8f6e into master Aug 13, 2021
@kriskowal kriskowal deleted the 527-agoric branch August 13, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants