fix(swingset)!: remove stats from vatAdmin API #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to see a change that removes Pegasus's dependency on It's fine if you land this without fixing that, though. |
warner
force-pushed
the
3331-remove-stats
branch
from
4a929ef to
3d8bfef
Compare
The "Admin Node" returned by `vatAdmin~.createVatDynamically()` had a method named `adminData()`, which returned some statistics like the number of objects imported into the vat. This wasn't super-useful and exposes a little too much information about the kernel's internals, especially as GC starts to get more interesting. So we've decided to remove this API. closes #3331
warner
force-pushed
the
3331-remove-stats
branch
from
3d8bfef to
8fd3fdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Admin Node" returned by
vatAdmin~.createVatDynamically()had a methodnamed
adminData(), which returned some statistics like the number ofobjects imported into the vat. This wasn't super-useful and exposes a little
too much information about the kernel's internals, especially as GC starts to
get more interesting. So we've decided to remove this API.
closes #3331