Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: for Keplr support (and presumably other wallets) we need CORS #3324

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

michaelfig
Copy link
Member

A small tweak to allow easily toggling the CORS Access-Control-Allow-Origin header to "*" for deployed "peer" machines, or if there are none, for deployed "validator" machines.

This is needed for the Keplr integration.

@michaelfig michaelfig added agoric-cli package: agoric-cli deployment Chain deployment mechanism (e.g. testnet) labels Jun 15, 2021
@michaelfig michaelfig requested review from kriskowal and dckc June 15, 2021 02:33
@michaelfig michaelfig self-assigned this Jun 15, 2021
@michaelfig michaelfig enabled auto-merge June 15, 2021 02:41
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little fuzzy on finishTendermintConfig and such, but I skimmed this change, and in general, yes, CORS is the norm for any API target. And since we don't use ambient authority such as cookies, this shouldn't introduce any significant risks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cli package: agoric-cli deployment Chain deployment mechanism (e.g. testnet)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants