feat: epoched reward distribution #3288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
reviewed
Jun 13, 2021
golang/cosmos/x/vbank/vbank.go
Outdated
| coins := make([]sdk.Coin, 0) | ||
| if blocks > 0 { | ||
| for _, coin := range pool { | ||
| amt := coin.Amount.Int64() |
There was a problem hiding this comment.
Just to be pedantic, please don't cast a coin.Amount to an Int64, since it technically could overflow. Please use sdk.Int comparisons and math instead.
This may seem silly at this point, but if we ever decide to use coins which are represented in about 18 decimalPlaces (such as most coins transferred from Ethereum), we quickly overflow Int64.
There was a problem hiding this comment.
Done. Checked that this was the only int64 assumption and added a test with large amounts.
First, buffer the rewards in the vbank module.
When fees are sent to vbank at the epoch, calculate a rate for distributing them to exhaust the reward pool by theend of the epoch.
JimLarson
force-pushed
the
3114-epoch-rewards
branch
from
af67446 to
fabfacb
Compare
This was referenced Sep 15, 2021
Open
Open
Open
Open
Open
This was referenced Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3114