Suggestion for 3184 -- decrement first #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #3184 (comment) |
katelynsills
pushed a commit
that referenced
this pull request
Jun 4, 2021
* fix: regexp magic * fix: lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where the increment was nested inside the decrement in #3184, swap them.
For cases like this, I think it is more intuitive to put the decrement on the inside. It fits with our physical conservation intuitions: The amounts in the decrement's return value are the amounts extracted from the decremented seat's allocation. That amount in turn is used to increment the allocation of the outer seat.