Integrate JS RUN fees with the x/distribution module #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
3114-give-to-fee-collector
branch
from
889436a to
1bbf7dc
Compare
JimLarson
approved these changes
May 20, 2021
| }, | ||
| async pushAmount(amount) { | ||
| const value = AmountMath.getValue(feeKit.brand, amount); | ||
| await bankCall({ |
There was a problem hiding this comment.
I assume that this implicitly throws any error returned by the call?
There was a problem hiding this comment.
Yes, an async method always returns a promise. await x either returns the resolved value of x, or if x is rejected, throws the rejected reason (if uncaught, resulting in a rejected promise with the same reason).
Chris-Hibbert
approved these changes
May 20, 2021
| @@ -30,56 +26,28 @@ export function makeTreasuryFeeCollector(zoe, treasuryCreatorFacet) { | |||
| // remainder till the next epoch. | |||
|
|
|||
| /** @type {BuildFeeDistributor} */ | |||
| export function buildDistributor(treasury, bank, epochTimer, params) { | |||
| export async function buildDistributor( | |||
There was a problem hiding this comment.
Please update the comment above.
// A distributor of fees from treasury to the Bank module. Each time the
// epochTimer signals the end of an Epoch, it will ask
// the treasury for the fees that have been collected to date and send that
// payment to the depositFacet.
|
Note: #3114 |
michaelfig
force-pushed
the
3114-give-to-fee-collector
branch
from
1bbf7dc to
9c6e9f9
Compare
michaelfig
force-pushed
the
3114-give-to-fee-collector
branch
from
9c6e9f9 to
7e97cc1
Compare
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vpurse.epochDurationgenesis parameter,