feat(xsnap): performance monitoring / metering #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note this depends on agoric-labs/moddable#5 |
kriskowal
requested changes
May 4, 2021
1 task
kriskowal
approved these changes
May 4, 2021
kriskowal
force-pushed
the
3012-perf-xsnap
branch
2 times, most recently
from
d8e68e1 to
d2cfc45
Compare
Note the change of URL to agoric-labs - garbageCollectionCount - add/remove for map, set - maxBucketSize
flamegraph/perf/zoe.xnap/1814.66/1815.66 shows a lot of time spent in gc (fxRunID / fxNewChunk / fxMarkValue). This is likely a result of earlier tweaks to heap parameters (11795de). We observe that vats usually use around 30MB RSS, so let's start with that size heap (even though RSS is probably not all XS heap). If we need more, grow a substantial amount (4MB) at a time.
The allocationLimit was previously set to 10 times the amount of memory that the vats use on start-up. Until things like kernel GC are more in place, let's expand to 2GB.
This was referenced Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the successful parts of the experiments from #3012 .
depends on agoric-labs/moddable#5
cc @warner