test(ava-xs): integrate with ses-ava, install-ses-debug #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install-ses-debug installs SES and calls lockdown() with debugging options. In ava-xs, we avoid installing SES again (since it's already installed) but we have to set the lockdown() options to match so that things like error messsages match test expectations. So we make another copy of the SES bootstrap bundle that calls lockdown with debugging options. We also supply a stub `@agoric/ses-ava`.
kriskowal
approved these changes
Mar 29, 2021
|
hey! did you notice? All XS tests passed! The one that was failing was intermittent, so it could still be in there, but it was failing pretty regularly in ci. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install-ses-debug installs SES and calls lockdown() with debugging
options. In ava-xs, we avoid installing SES again (since it's already
installed) but we have to set the lockdown() options to match so
that things like error messsages match test expectations.
So we make another copy of the SES bootstrap bundle that calls
lockdown with debugging options.
We also supply a stub
@agoric/ses-ava.fixes: #2753