Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CI will run test:xs, but failures won't block PRs #2651

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

warner
Copy link
Member

@warner warner commented Mar 15, 2021

closes #2647

@warner warner added the tooling repo-wide infrastructure label Mar 15, 2021
@warner warner self-assigned this Mar 15, 2021
@warner warner mentioned this pull request Mar 15, 2021
@warner warner requested review from dckc and michaelfig March 15, 2021 23:05
The amount of Node.js code that runs under `test:xs` is minimal and not very
interesting, so save time by only running test:xs under node-14.x .

closes #2647
@warner warner force-pushed the 2647-xs-ci-optional branch from a2327f5 to 33fc79c Compare March 15, 2021 23:17
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

presuming ci runs as expected, this looks good.

@warner
Copy link
Member Author

warner commented Mar 15, 2021

Ok, the "Test all Packages / test-xs (14.x) (pull_request) Successful in 4m" at the bottom of the Checks list means this is correctly running the XS tests. Once it lands, I'll update my other PR (which triggers an XS failure) and see if reports something like "Failed but ignored" as it now should.

@michaelfig
Copy link
Member

michaelfig commented Mar 16, 2021 via email

@warner warner merged commit 41748eb into master Mar 16, 2021
@warner warner deleted the 2647-xs-ci-optional branch March 16, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling repo-wide infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make XS CI optional
3 participants