fix: hush "replaying transcripts" message during swingset startup #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes one of the two noisy log messages from kernel startup. This mostly gets noticed in tests like test-message-patterns.js which launches dozens of swingsets in a single test. We included it because sometimes errors occur (and get logged to the console) during transcript replay, and it wasn't obvious when/why the vat was being invoked so early. But to be properly useful for that, we'd need to announce the replay phase of each vat separately, as well as the *end* of replay for each vat, multiplying the noise by at least an order of magnitude. Instead, just remove the message, and if/when someone needs to figure this out, go ahead and temporarily add it back. Besides, transcript replay is going to change drastically with the introduction of the vat-manager-manger (#2277), which would have removed the place where this message was emitted anyways.
erights
pushed a commit
that referenced
this pull request
Feb 12, 2021
) This removes one of the two noisy log messages from kernel startup. This mostly gets noticed in tests like test-message-patterns.js which launches dozens of swingsets in a single test. We included it because sometimes errors occur (and get logged to the console) during transcript replay, and it wasn't obvious when/why the vat was being invoked so early. But to be properly useful for that, we'd need to announce the replay phase of each vat separately, as well as the *end* of replay for each vat, multiplying the noise by at least an order of magnitude. Instead, just remove the message, and if/when someone needs to figure this out, go ahead and temporarily add it back. Besides, transcript replay is going to change drastically with the introduction of the vat-manager-manger (#2277), which would have removed the place where this message was emitted anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes one of the two noisy log messages from kernel startup. This
mostly gets noticed in tests like test-message-patterns.js which launches
dozens of swingsets in a single test. We included it because sometimes errors
occur (and get logged to the console) during transcript replay, and it wasn't
obvious when/why the vat was being invoked so early. But to be properly
useful for that, we'd need to announce the replay phase of each vat
separately, as well as the end of replay for each vat, multiplying the
noise by at least an order of magnitude.
Instead, just remove the message, and if/when someone needs to figure this
out, go ahead and temporarily add it back. Besides, transcript replay is
going to change drastically with the introduction of the
vat-manager-manger (#2277), which would have removed the place where this
message was emitted anyways.