Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ses 0.12.2 release #2323

Merged
merged 4 commits into from
Feb 6, 2021
Merged

Upgrade to ses 0.12.2 release #2323

merged 4 commits into from
Feb 6, 2021

Conversation

erights
Copy link
Member

@erights erights commented Feb 3, 2021

Inherit all the recent debugging goodness!

@erights erights requested review from dckc and michaelfig February 3, 2021 04:13
@erights erights self-assigned this Feb 3, 2021
@erights erights changed the title Upgrade to ses to 0.12.1 release Upgrade to ses 0.12.1 release Feb 3, 2021
@erights erights changed the title Upgrade to ses 0.12.1 release WIP Upgrade to ses 0.12.1 release Feb 3, 2021
@erights erights marked this pull request as draft February 3, 2021 04:28
@dckc
Copy link
Member

dckc commented Feb 3, 2021

fixes #2263

@dckc
Copy link
Member

dckc commented Feb 5, 2021

@erights I suspect we need a release of ses that includes endojs/endo#571

@erights
Copy link
Member Author

erights commented Feb 5, 2021

@erights I suspect we need a release of ses that includes Agoric/SES-shim#571

ok

@erights
Copy link
Member Author

erights commented Feb 5, 2021

@dckc If you haven't started cutting that new release, hold off a moment. There's one more small change I'd like to get in.

@erights
Copy link
Member Author

erights commented Feb 5, 2021

@dckc If you haven't started cutting that new release, hold off a moment. There's one more small change I'd like to get in.

For the record, that was endojs/endo#572 , now merged.

@dckc
Copy link
Member

dckc commented Feb 5, 2021

xsnap seems to get along with 0.12.2

@erights erights force-pushed the markm-upgrade-ses-dependency branch from 025eda9 to 6943510 Compare February 6, 2021 00:19
@erights erights changed the title WIP Upgrade to ses 0.12.1 release WIP Upgrade to ses 0.12.2 release Feb 6, 2021
@erights erights changed the title WIP Upgrade to ses 0.12.2 release Upgrade to ses 0.12.2 release Feb 6, 2021
@erights erights marked this pull request as ready for review February 6, 2021 01:03
@erights
Copy link
Member Author

erights commented Feb 6, 2021

@dckc @michaelfig Ready for review.

@michaelfig I think you'll be amused why I had to fix your fix to the bundle test ;)

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It was amusing.

@erights erights merged commit 04f6f81 into master Feb 6, 2021
@erights erights deleted the markm-upgrade-ses-dependency branch February 6, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants