feat(swingset): defaultManagerType option in makeSwingsetController #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
force-pushed
the
2260-xs-all-option
branch
2 times, most recently
from
18eb7fb to
df4b0ed
Compare
dckc
force-pushed
the
2260-xs-all-option
branch
from
df4b0ed to
42ffa42
Compare
dckc
commented
Jan 28, 2021
dckc
commented
Jan 28, 2021
This was referenced Feb 1, 2021
dckc
force-pushed
the
2260-xs-all-option
branch
2 times, most recently
from
3c2b51b to
5184f71
Compare
dckc
force-pushed
the
2260-xs-all-option
branch
from
5184f71 to
3269e5c
Compare
|
@warner I think this is ready for review. It definitely needs fresh eyes. I've been staring at it for way too long. |
warner
reviewed
Feb 8, 2021
|
Other than that one note to add, it looks good. Add that and rebase to current trunk (fixing the conflict in |
ref attachment from PH Tue Feb 2 07:28:28 2021 -0800 - don't hold arraybuffer pointer across macros - replace C stack report / result with xsVar(1) and xsVar(2)
- accept std regex range
- route call to manager - some VatPowers type annotations, esp. transformTildot
we get an empty JSON response for at least vatstoreSet These are missing from SwingSet/docs/vat-worker.md
... and to buildVatController Usage: WORKER_TYPE=xs-worker yarn test or: XSNAP_DEBUG=1 WORKER_TYPE=xs-worker yarn test or: XSNAP_DEBUG=1 WORKER_TYPE=xs-worker yarn test --watch ref #2260 - fix: comms vat must be local to use setUp - chore(swingset): log fallback-to-local workerType - chore: refine xs-worker diagnostics - chore(xs-worker): include vatID in log messages - fix(xs-worker): catch exceptions from exception handler - chore(swingset): use ambient process.env unless caller overrides - fix(swingset): proplems in types.js shown by @ts-check
dckc
force-pushed
the
2260-xs-all-option
branch
from
3269e5c to
a9aa181
Compare
warner
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2260
todo:
but I'd like to start getting feedback from the ci bots...