Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet fixes #1991

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Wallet fixes #1991

merged 3 commits into from
Nov 6, 2020

Conversation

michaelfig
Copy link
Member

These updates:

  • provide full support for decimals in the wallet proposals
  • reclaim any unclaimed payments left over after attempting to deposit payouts (before, they would just be lost)
  • help prevent a foot gun where yarn link-cli would overwrite existing files

@michaelfig michaelfig added this to the Chainlink Hackathon milestone Nov 6, 2020
@michaelfig michaelfig self-assigned this Nov 6, 2020
katelynsills
katelynsills approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelfig michaelfig merged commit 36ce679 into master Nov 6, 2020
@michaelfig michaelfig deleted the mfig/wallet-fixes branch November 6, 2020 04:40
This was referenced Nov 28, 2020
Open
Open
This was referenced Oct 22, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katelynsills katelynsills katelynsills approved these changes

@FUDCo FUDCo Awaiting requested review from FUDCo

@Chris-Hibbert Chris-Hibbert Awaiting requested review from Chris-Hibbert

Assignees

@michaelfig michaelfig

Labels
wallet
Projects
None yet
Milestone
Chainlink Hackathon
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelfig @katelynsills