-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit of MarkM's original doc incorporating ChrisH comments #1969
Conversation
Yes. The term "reason" is conventional which is why I encouraged us to adopt it and why I'm using it. But the unqualified phrase "reason for failure" suggests a stronger claim than we intend. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments so far.
I still have yet to review starting at "# SubscriptionKit"
Can we say "the reason that was given for the failure"? Or "the reason the publisher gave"? It may be that we don't know whether they were right, but we do know that it was the reason we were given. |
I like that direction. How about "reported reason"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This review pass done.
Finished cleaning up PR comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads much better than the original. Thanks!
LGTM
1978ad4
to
09cf55f
Compare
Chris, the "alleged" you had questions about is on line 32. The comments on the Google Doc were: Chris: "Why is this 'alleged'? Was that wording used in the source doc?" and my response was Tom: "The original wording was "reporting an alleged reason for its failure"". Feel free to change what's there if you don't think it's correct.
Other general question I have is whether this is about makeNotifer/SubscriptionKits or about Notifiers and Subscriptions. If the latter, should do a quick pass to change a lot of the Kit wording to just the type.