Avoid database reentrancy issue during parallel testing #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUDCo
added
bug
|
Fixes #1679 |
FUDCo
force-pushed
the
fix-swingset-runner-test-reentrancy-problem
branch
from
eb2028d to
82bb33e
Compare
michaelfig
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ava's parallel test execution was causing some of the swingset-runner tests to intermittently step on each other's database state, resulting in test flakiness. Tests now run with each using its own temporary database file.
To achieve this swingset-runner has acquired a command line option to let you put the database someplace other than the default location for the swingset, which might be useful in other circumstances too.