Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert overspill from PR #1577 #1647

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Revert overspill from PR #1577 #1647

merged 2 commits into from
Aug 31, 2020

Conversation

erights
Copy link
Member

@erights erights commented Aug 31, 2020

Revert overspill from PR #1577 . For these occurrences of 'presence', they should stay 'presence' even when passStyleOf and marshal change from 'presence' to 'remote'.

@erights erights requested a review from warner August 31, 2020 00:10
@erights erights mentioned this pull request Aug 31, 2020
Merged
warner
warner approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the quick fix

@erights erights merged commit dfff728 into master Aug 31, 2020
@erights erights deleted the revert-overspill branch August 31, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warner warner warner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @warner