Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up E.when and E.resolve #1561

Merged
merged 3 commits into from
Aug 20, 2020
Merged

fix: clean up E.when and E.resolve #1561

merged 3 commits into from
Aug 20, 2020

Conversation

erights
Copy link
Member

@erights erights commented Aug 19, 2020

Fixes #1364

See also #1361

@erights erights requested a review from michaelfig August 19, 2020 22:29
michaelfig
michaelfig approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo test failures.

packages/notifier/test/test-notifier-adaptor.js Show resolved Hide resolved
@erights erights merged commit 634046c into master Aug 20, 2020
@erights erights deleted the e-when branch August 20, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix odd use of E.when
2 participants
@erights @michaelfig