fix: deprecate getMathHelpersName for getMathHelperName #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT, the only publicly exposed API using the plural "mathHelpers" are the
getMathHelpersNamemethods. Since we're about to do a major release, it's worth deprecating them, introducing the singular instead, and changing all uses in this PR to use the singular form.There are many other uses of the plural that will need to be changed as well, such as variables, types, comments and documentation. But non of these create painful cross version compat problems. In the interest of minimizing spurious merge conflicts before major merging, I omitted all these others.
So that I could test and see I didn't break anything, I did this as a delta on master rather than new-zoe-spike-2.