Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add a version check assertion to enforce Golang 1.14+ #1255

Merged
merged 2 commits into from
Jul 3, 2020
Merged

fix: add a version check assertion to enforce Golang 1.14+ #1255

merged 2 commits into from
Jul 3, 2020

Conversation

michaelfig
Copy link
Member

This prevents the annoying #1253 behaviour when an older Golang is in use.

@michaelfig michaelfig added the cosmic-swingset package: cosmic-swingset label Jul 3, 2020
@michaelfig michaelfig self-assigned this Jul 3, 2020
FUDCo
FUDCo approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@michaelfig michaelfig merged commit ada087e into master Jul 3, 2020
@michaelfig michaelfig deleted the mfig/version-check branch July 3, 2020 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FUDCo FUDCo FUDCo approved these changes

@kriskowal kriskowal Awaiting requested review from kriskowal

Assignees

@michaelfig michaelfig

Labels
cosmic-swingset package: cosmic-swingset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelfig @FUDCo