Don't use the LMDB useWritemap
option if we know we don't need it
#1123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LMDB
useWritemap
option, which was required for LMDB to work properly when running on WSL, unconditionally creates a ~2GB database file (even though it doesn't actually take up that much space on disk until you actually put that much data in). This makes it hard to measure database space usage by looking at the file size, since now the file size is constant. However, if we know we are running on an OS where we know LMDB works without theuseWritemap
option, we can do without it and return to a world where we can get useful measurements of database space usage. MacOS is one such, so at a minimum we can exempt that, which is what this change does. It's possible that we could cook up some more sophisticated way to test for WSL specifically, but this much simpler test is doable immediately.