Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't bypass the block queue when running simulateBlock #1118

Merged
merged 1 commit into from
May 17, 2020
Merged

Don't bypass the block queue when running simulateBlock #1118

merged 1 commit into from
May 17, 2020

Conversation

michaelfig
Copy link
Member

Due to a mistaken shadowing of the queued simulateBlock function with the inner unqueued function, the simulateBlock was not always using the queue. This caused subtle and unpredictable data races when running the simulated chain.

This PR renames the inner definition to unqueuedSimulateBlock so that the queued version is always used, notably within that function as an argument to setTimeout.

@michaelfig michaelfig added bug Something isn't working cosmic-swingset package: cosmic-swingset labels May 17, 2020
@michaelfig michaelfig requested a review from dtribble May 17, 2020 03:57
@michaelfig michaelfig self-assigned this May 17, 2020
@michaelfig michaelfig merged commit 50caaa6 into master May 17, 2020
@michaelfig michaelfig deleted the mfig/prevent-blockq-bypass branch May 17, 2020 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtribble dtribble dtribble approved these changes

Assignees

@michaelfig michaelfig

Labels
bug Something isn't working cosmic-swingset package: cosmic-swingset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelfig @dtribble