Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail hard if there is no $BOOT_ADDRESS #1048

Merged
merged 1 commit into from
May 4, 2020
Merged

Fail hard if there is no $BOOT_ADDRESS #1048

merged 1 commit into from
May 4, 2020

Conversation

michaelfig
Copy link
Member

Closes #1044

This is an easy mistake to make, so we should warn of it early rather than when the bootstrap address is used later in a transaction.

@michaelfig michaelfig requested review from FUDCo, kriskowal and warner May 4, 2020 04:10
@michaelfig michaelfig self-assigned this May 4, 2020
@michaelfig michaelfig added the cosmic-swingset package: cosmic-swingset label May 4, 2020
dckc
dckc reviewed May 4, 2020
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that static typing should catch?

@michaelfig
Copy link
Member Author

Is this something that static typing should catch?

Yes, if it forced me into a Maybe monad, so I was forced to think about the "not set" case.

@michaelfig michaelfig force-pushed the mfig/fail-with-no-boot-addr branch from 7fe0109 to 82d538a Compare May 4, 2020 08:02
@michaelfig michaelfig force-pushed the mfig/fail-with-no-boot-addr branch from 82d538a to eeb2592 Compare May 4, 2020 08:09
@dckc
Copy link
Member

dckc commented May 4, 2020

Is this something that static typing should catch?
Yes, if it forced me into a Maybe monad, ...

I think the type of process.env.BOOT_ADDRESS is string?, which is pretty much Maybe string.

warner
warner approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelfig michaelfig merged commit e6e1736 into master May 4, 2020
@michaelfig michaelfig deleted the mfig/fail-with-no-boot-addr branch May 4, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc left review comments

@warner warner warner approved these changes

@FUDCo FUDCo Awaiting requested review from FUDCo

@kriskowal kriskowal Awaiting requested review from kriskowal

Assignees

@michaelfig michaelfig

Labels
cosmic-swingset package: cosmic-swingset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coredumped with initial sync at 35 block
3 participants
@michaelfig @dckc @warner