test(cosmic-swingset): Include the last three lines of stderr when a make test fails
#10438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`make` test fails
michaelfig
approved these changes
Nov 9, 2024
Comment on lines
16
to
24
| /** @type {Promise<string> | undefined} */ | ||
| let stderrP = Promise.resolve(''); | ||
| // https://nodejs.org/docs/latest/api/child_process.html#optionsstdio | ||
| let { stdio = 'pipe' } = opts; | ||
| if (stdio === 'ignore' || stdio[2] === 'ignore') { | ||
| stderrP = undefined; | ||
| stdio = typeof stdio === 'string' ? [stdio, stdio, stdio] : [...stdio]; | ||
| stdio[2] = 'pipe'; | ||
| } |
There was a problem hiding this comment.
This is just my style. Feel free to ignore:
Suggested change
| /** @type {Promise<string> | undefined} */ | |
| let stderrP = Promise.resolve(''); | |
| // https://nodejs.org/docs/latest/api/child_process.html#optionsstdio | |
| let { stdio = 'pipe' } = opts; | |
| if (stdio === 'ignore' || stdio[2] === 'ignore') { | |
| stderrP = undefined; | |
| stdio = typeof stdio === 'string' ? [stdio, stdio, stdio] : [...stdio]; | |
| stdio[2] = 'pipe'; | |
| } | |
| /** @type {Promise<string> | undefined} */ | |
| let stderrP; | |
| // https://nodejs.org/docs/latest/api/child_process.html#optionsstdio | |
| let { stdio = 'pipe' } = opts; | |
| if (stdio === 'ignore' || stdio[2] === 'ignore') { | |
| stdio = typeof stdio === 'string' ? [stdio, stdio, stdio] : [...stdio]; | |
| stdio[2] = 'pipe'; | |
| } else { | |
| stderrP = Promise.resolve('') | |
| } |
There was a problem hiding this comment.
Thanks, that does read a bit better.
…when a make test fails
Deploying agoric-sdk with
|
| Latest commit: |
b6ac6b3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b97e7baf.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2024-11-scenario2-pre.agoric-sdk.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #10165 to independently resolve a preëxisting TODO.
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
Makes it easier to debug failures in
make-dependent cosmic-swingset tests.Upgrade Considerations
n/a