-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(a3p): extend test coverage for Vaults on z:acceptance #10280
Open
Jorge-Lopes
wants to merge
15
commits into
master
Choose a base branch
from
jorge/acceptance-vauts-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with Cloudflare Pages
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: Agoric/BytePitchPartnerEng#22
closes: Agoric/BytePitchPartnerEng#15
Description
The purpose of this PR is to extend the
z:acceptance
testing coverage ofVaults
to include the following cases:The existing tests were also refactored to take advantage of the new helper functions built and also included in this PR.
In addition to extending the test cases, other key updates are as follows:
pushPrice.js
script was introduced to setup the oracles and push prices for the desired brands in theuse
phase off:replace-price-feeds
proposal.f:replace-price-feeds/priceFeedUpdate.test.js
to reflect the new price feed handling.openVault.js
script was introduced to open a new vault in theuse
phase ofn:upgrade-next
proposalA more detailed discussion of the decisions made for the implementations above can be found on the issue: Agoric/BytePitchPartnerEng#22
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
This PR included a new file,
/z:acceptance/test-lib/ratio.js
, which exports the methodceilMultiplyBy
, which is also exported by the@agoric/zoe
package.The reason why this file was created was because when trying to install the
@agoric/zoe
package at the a3p-integration z:acceptance proposal, it failed because@agoric/xsnap
package couldn't be built successfully.As described in the issue #10259
When resolved, the
ratio.js
file should be removed and theceilMultiplyBy
method should be imported from the@agoric/zoe
package.Upgrade Considerations
none