chore: update devnet config for EC members #10251
Conversation
| voterAddresses: { | ||
| gov1: 'agoric1ldmtatp24qlllgxmrsjzcpe20fvlkp448zcuce', | ||
| gov2: 'agoric140dmkrz2e42ergjj7gyvejhzmjzurvqeq82ang', | ||
| gov3: 'agoric1f0h5zgxyg3euxsqzs0506uj4cmu56y30pqx46s', |
There was a problem hiding this comment.
Yes, gov3 is actually gov4 in my sequential numbering. Sorry for any confusion! Do you suggest naming it gov4?
| addressesToAdd: ['agoric1f0h5zgxyg3euxsqzs0506uj4cmu56y30pqx46s'], | ||
| addressesToRemove: ['agoric1w8wktaur4zf8qmmtn3n7x3r0jhsjkjntcm3u6h'], |
There was a problem hiding this comment.
how do we remove ...u6h? I don't see it listed in voterAddresses.
There was a problem hiding this comment.
The voterAddresses map includes the addresses that will be invited to join the new committee and charter. The lists addressesToAdd and addressesToRemove are linked to highPrioritySenders. The new member ...x46s, has been added to addressesToAdd. An outgoing member from the previous committee, ...u6h, has been placed in addressesToRemove.
There was a problem hiding this comment.
ok... I recognize ...u6h as gov3 now, and I see it's in the devnet highPrioritySenders.
|
Again, this can't be in service to #10209 ; that issue is for post code complete testing; that is: stuff that happens after all git commits. I think the relevant issue here is: |
Deploying agoric-sdk with
|
| Latest commit: |
7a4395b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e1bbb074.agoric-sdk.pages.dev |
| Branch Preview URL: | https://rs-update-replaceelectorate.agoric-sdk.pages.dev |
|
Upgrade considerations are actually non-trivial. I think we're running this core-eval as part of a chain-halting upgrade, so we need to make sure it's hooked into the go upgrade handler. IOU an issue, I suppose. I suggest changing "n/a" to "out of scope of this PR; see an upcoming issue". I suggest combining Security Considerations, Documentation Considerations and Testing Considerations into one section: Security / Documentation / Testing ConsiderationsThese accounts are for testing. The usual key management considerations apply. The relevant private keys are shared on a need-to-know basis for testing. |
rabi-siddique
force-pushed
the
rs-update-replaceElectorate-config
branch
from
831ab04 to
a97a07d
Compare
rabi-siddique
added
the
automerge:rebase
rabi-siddique
force-pushed
the
rs-update-replaceElectorate-config
branch
from
a97a07d to
7a4395b
Compare
refs: #10194
Description
The PR updates the
DEVNETconfig in the builder script of replace electorate core eval, which is identical for all testnets. It includes the wallet address of the new EC committee member and adds this address to the high-priority senders list.Scaling Considerations
n/a
Upgrade Considerations
out of scope of this PR; see an upcoming issue
Security / Documentation / Testing Considerations
These accounts are for testing. The usual key management considerations apply. The relevant private keys are shared on a need-to-know basis for testing.