Replace priceFeeds and scaledPriceAuthority #9928
Assignees
Labels
Comments
Chris-Hibbert
added
contract-upgrade
oracle
This was referenced Sep 3, 2024
mergify bot
added a commit
that referenced
this issue
Sep 10, 2024
refs: #9928 ## Description Clean up in a3p-integration, as a follow-up to the vaults&auctions release on mainNet, and [addition of that release to `agoric-3-proposals`](Agoric/agoric-3-proposals#172). ### Security Considerations N/A ### Scaling Considerations N/A ### Documentation Considerations I will add more details of this process to CONTRIBUTING in a-3-p. ### Testing Considerations keeping things clean so testing can continue. ### Upgrade Considerations upgrade and iterate!
mergify bot
added a commit
that referenced
this issue
Oct 9, 2024
closes: #9584 closes: #9928 refs: #9827 refs: #9748 refs: #9382 closes: #10031 ## Description We added upgrading the scaledPriceAuthority to the steps in upgrading vaults, auctions, and priceFeeds, and didn't notice that it broke things. The problem turned out to be that the "priceAuthority" object registered with the priceFeedRegistry was an ephemeral object that was not upgraded. This fixes that by re-registering the new priceAuthority. Then, to simplify the process of cleaning up the uncollected cycles reported in #9483, we switched to replacing the scaledPriceAuthorities rather than upgrading them. We also realized that we would need different coreEvals in different environments, since the Oracle addresses and particular assets vary for each (test and mainNet) chain environment. #9748 addressed some of the issues in the original coreEval. #9999 showed what was needed for upgrading priceFeeds, which was completed by #9827. #10021 added some details on replacing scaledPriceAuthorities. ### Security Considerations N/A ### Scaling Considerations Addresses one of our biggest scaling issues. ### Documentation Considerations N/A ### Testing Considerations Thorough testing in a3p, and our testnets. #9886 discusses some testing to ensure Oracles will work with the upgrade. ### Upgrade Considerations See above
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 24, 2024
…aults receive quotes Refs: Agoric#9928 Refs: Agoric/BytePitchPartnerEng#25
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 24, 2024
…aults receive quotes Refs: Agoric#9928 Refs: Agoric/BytePitchPartnerEng#25
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 24, 2024
…js` to the changes `priceFeed.test.js` introduces Refs: Agoric/BytePitchPartnerEng#25 Refs: Agoric#9928
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 24, 2024
…aults receive quotes Refs: Agoric#9928 Refs: Agoric/BytePitchPartnerEng#25 fix: lint fixes Refs: Agoric/BytePitchPartnerEng#25
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 24, 2024
…js` to the changes `priceFeed.test.js` introduces Refs: Agoric/BytePitchPartnerEng#25 Refs: Agoric#9928
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 24, 2024
…js` to the changes `priceFeed.test.js` introduces Refs: Agoric/BytePitchPartnerEng#25 Refs: Agoric#9928 fix: clear unused code
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 24, 2024
…js` to the changes `priceFeed.test.js` introduces Refs: Agoric/BytePitchPartnerEng#25 Refs: Agoric#9928 fix: clear unused code fix: prettier fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
The price-feed and scaledPriceAuthority vats are retaining old QuotePayments (see #8400), causing storage to grow. Once this is in place, we can consider #9483.
Description of the Design
Replace all of them with new instances, then reconnect oraclees, and reset Auctions and Vaults to listen to the new contracts as sources of price info.
See also: #9382, #9748
Security Considerations
Pay attention to chain and contract integrity. No other conventional security issues.
Scaling Considerations
It addresses a scaling issue.
Test Plan
Validate that at the end auctions and vaults are getting prices from Oracles, and the old priceFeed and scaledPriceAuthority contracts are quiescent.
Upgrade Considerations
It's all upgrade.
The text was updated successfully, but these errors were encountered: