Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake in gc-kernel device-transfer call to retireImports #9089

Closed
turadg opened this issue Mar 13, 2024 · 3 comments · Fixed by #9132
Closed

flake in gc-kernel device-transfer call to retireImports #9089

turadg opened this issue Mar 13, 2024 · 3 comments · Fixed by #9132
Assignees
@warner
Labels
hygiene Tidying up around the house SwingSet package: SwingSet

Comments

@turadg
Copy link
Member

turadg commented Mar 13, 2024

What is the Problem Being Solved?

Similar to #8883 but distinct,

not ok 4 - gc-kernel › device transfer %ava-dur=24931ms
  ---
    name: AssertionError
    assertion: is
    values:
      'Difference (- actual, + expected):': |-
        - '2,2'
        + '1,1'
    at: 'packages/SwingSet/test/test-gc-kernel.js:1[22](https://github.com/Agoric/agoric-sdk/actions/runs/8272299821/job/22633964312?pr=9086#step:6:23)6:5'
  ...
ok 5 - gc-kernel › sortVrefs %ava-dur=4ms
error during syscall translation: (Error#1)
Error#1: syscall.retireImports but o-50 is still reachable
  at packages/SwingSet/src/kernel/vatTranslator.js:437:15

Description of the Design

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations
@turadg turadg added the hygiene Tidying up around the house label Mar 13, 2024
@warner warner added the SwingSet package: SwingSet label Mar 23, 2024
@warner
Copy link
Member

warner commented Mar 23, 2024

This might be another instance of #3240 or #5575, although I have no idea why it might be showing up now. I'll make a PR that changes that test to use XS instead of Node, that's our usual fix.

@warner
Copy link
Member

warner commented Mar 23, 2024

Note the error during syscall translation: (Error#1) /
Error#1: syscall.retireImports but o-50 is still reachable is normal, one of the other tests in that file is deliberately provoking an error handler.

It's the 2,2 vs 1,1 that is the symptom of this GC problem.

warner added a commit that referenced this issue Mar 23, 2024
@warner
fix(swingset): force flaky GC test to use XS only
87882a8 
Sometimes, for reasons we don't entirely understand, Node.js doesn't
garbage-collect objects when we tell it to, and we get flaky
GC-checking tests. This applies our usual fix, which is to only run
those tests under XS.

refs #3240
refs #5575
fixes #9089
warner added a commit that referenced this issue Mar 23, 2024
@warner
fix(swingset): force flaky GC test to use XS only
f3e1a21 
Sometimes, for reasons we don't entirely understand, Node.js doesn't
garbage-collect objects when we tell it to, and we get flaky
GC-checking tests. This applies our usual fix, which is to only run
those tests under XS.

It also stops attempting to use `test.serial` as a workaround.

refs #3240
refs #5575
fixes #9089
@warner warner mentioned this issue Mar 23, 2024
Merged
warner added a commit that referenced this issue Mar 26, 2024
@warner
fix(swingset): force flaky GC test to use XS only
d2961e2 
Sometimes, for reasons we don't entirely understand, Node.js doesn't
garbage-collect objects when we tell it to, and we get flaky
GC-checking tests. This applies our usual fix, which is to only run
those tests under XS.

It also stops attempting to use `test.serial` as a workaround.

refs #3240
refs #5575
fixes #9089
@turadg
Copy link
Member Author

turadg commented Mar 27, 2024

Got this again in https://github.com/Agoric/agoric-sdk/actions/runs/8457659593/job/23170228389?pr=8850

turadg pushed a commit that referenced this issue Mar 27, 2024
@warner @turadg
fix(swingset): force flaky GC test to use XS only
a3fe3be 
Sometimes, for reasons we don't entirely understand, Node.js doesn't
garbage-collect objects when we tell it to, and we get flaky
GC-checking tests. This applies our usual fix, which is to only run
those tests under XS.

It also stops attempting to use `test.serial` as a workaround.

refs #3240
refs #5575
fixes #9089
@mergify mergify bot closed this as completed in #9132 Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warner warner

Labels
hygiene Tidying up around the house SwingSet package: SwingSet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(swingset): force flaky GC test to use XS only Agoric/agoric-sdk
2 participants
@turadg @warner