Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auction starts based on current oracle price; not locked price #6948

Closed
rowgraus opened this issue Feb 8, 2023 · 4 comments
Closed

Auction starts based on current oracle price; not locked price #6948

rowgraus opened this issue Feb 8, 2023 · 4 comments
Assignees
Labels
vaults_triage DO NOT USE

Comments

@rowgraus
Copy link

rowgraus commented Feb 8, 2023

No description provided.

@Chris-Hibbert
Copy link
Contributor

I think the title is describing a (predicted) bug rather than the desired state. The current version of the PR (#7000) uses the most recent locked price as the basis for starting the auction. I think this is what we want.

@Chris-Hibbert
Copy link
Contributor

Chris-Hibbert commented Mar 29, 2023 via email

@otoole-brendan
Copy link
Contributor

@Chris-Hibbert I deleted my comment as I had incorrectly conflated the price we use for creating/adjusting vaults (which is the most conservative) - in this case you are right, we use current oracle price for auction start not locked price. Apologies for the confusion!

@Chris-Hibbert
Copy link
Contributor

We agreed that the current behavior is correct.

The auction uses the locked price for deciding which vaults to liquidate. When the auction starts, the prices are based on the most recent oracle price, scaled up or down according to the parameters. Every round of the auction is scaled from the single oracle price captured at the starting time of the auction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vaults_triage DO NOT USE
Projects
None yet
Development

No branches or pull requests

4 participants