Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid globalThis shim when not needed? #63

Closed
dckc opened this issue Oct 23, 2019 · 2 comments
Closed

avoid globalThis shim when not needed? #63

dckc opened this issue Oct 23, 2019 · 2 comments
Assignees
@dckc
Labels
enhancement New feature or request SwingSet package: SwingSet xsnap the XS execution tool

Comments

@dckc
Copy link
Member

dckc commented Oct 23, 2019

xs gripes:

...SwingSet/src/controller.js (24) # Exception: cannot coerce undefined to object!.

When I comment out the unshift line, xs is happy. I'm pretty sure it's not needed in xs; xs provides globalThis in every compartment. Can we skip this unshift on platforms where it's not needed?

https://github.com/Agoric/SwingSet/blob/e103ff770ca083987ff7b824057780ea1813d15d/src/controller.js#L22-L24
@warner warner transferred this issue from Agoric/SwingSet Dec 1, 2019
@warner warner added the SwingSet package: SwingSet label Dec 1, 2019
dckc pushed a commit to dckc/agoric-sdk that referenced this issue Dec 5, 2019
@jackzampolin
Merge PR Agoric#63: Add ledger chinese documentation
aa29de2 
R4R: Translate document of ledger to chinese. Related: Agoric#62
dckc pushed a commit to dckc/agoric-sdk that referenced this issue Dec 5, 2019
@erights
Merge pull request Agoric#63 from Agoric/link-installations
0497ccf 
link installations rather than concating code
dckc pushed a commit to dckc/agoric-sdk that referenced this issue Dec 5, 2019
@michaelfig
Merge pull request Agoric#63 from Agoric/raise-system-limits
da4dcc8 
Raise throughput limits
@dckc dckc self-assigned this Jan 15, 2021
@dckc dckc added invalid This doesn't seem right enhancement New feature or request and removed invalid This doesn't seem right labels Jan 15, 2021
@dckc
Copy link
Member Author

dckc commented Jan 15, 2021

According to the design in #2107 , we're not running the controller on xs , for now.

@dckc dckc added the xsnap the XS execution tool label Apr 28, 2021
@dckc
Copy link
Member Author

dckc commented May 11, 2021

fixed in 341718b

@dckc dckc closed this as completed May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dckc dckc

Labels
enhancement New feature or request SwingSet package: SwingSet xsnap the XS execution tool
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@warner @dckc