Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix extract-transcript and replay-transcript tools #5602

Closed
warner opened this issue Jun 15, 2022 · 0 comments · Fixed by #5688
Closed

fix extract-transcript and replay-transcript tools #5602

warner opened this issue Jun 15, 2022 · 0 comments · Fixed by #5688
Assignees
@warner
Labels
enhancement New feature or request SwingSet package: SwingSet
Milestone
Mainnet 1 RC0

Comments

@warner
Copy link
Member

warner commented Jun 15, 2022

What is the Problem Being Solved?

While investigating #5571 and #5587, I found that my tools for transcript extraction/replay had bitrotted. The task is to update them.

  • transcript extraction needs to capture the whole syscall result, even for failed syscalls
  • gcEveryCrank must be true, else GC is entirely disabled
  • replay now uses the whole syscall result, even for failed syscalls
  • the fake kernelKeeper needs getEnableFakeDurable
  • the fake kernelSlog needs delivery() and syscall()
  • we should track deliveryNum and try to align it with the original slog

Security Considerations

None, this is for a diagnostic tool

Test Plan

None, although if I'd put more energy into writing these tools in a form that could be tested, they probably wouldn't have bitrotted. I'm currently ok with that.
@warner warner added enhancement New feature or request SwingSet package: SwingSet labels Jun 15, 2022
@warner warner self-assigned this Jun 15, 2022
warner added a commit that referenced this issue Jun 29, 2022
@warner
fix(swingset): fix transcript extract/replay tools
15dbac1 
These had bitrotted:
* transcript now includes whole syscall result, even failures
* handle kerneldb bundleIDs
* new LMDB in swingstore
* gcEveryCrank=false else all GC is disabled (refs #5600)
* fake kernelKeeper/slogger needed new methods

The new code also attempts to track `deliveryNum`, to align it with
the original slog, but I'm not positive it is accurate.

closes #5602
@warner warner mentioned this issue Jun 29, 2022
Merged
warner added a commit that referenced this issue Jun 29, 2022
@warner @mergify
fix(swingset): fix transcript extract/replay tools
56e3d7c 
These had bitrotted:
* transcript now includes whole syscall result, even failures
* handle kerneldb bundleIDs
* new LMDB in swingstore
* gcEveryCrank=false else all GC is disabled (refs #5600)
* fake kernelKeeper/slogger needed new methods

The new code also attempts to track `deliveryNum`, to align it with
the original slog, but I'm not positive it is accurate.

closes #5602
@mergify mergify bot closed this as completed in #5688 Jun 29, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warner warner

Labels
enhancement New feature or request SwingSet package: SwingSet
Projects
None yet
Milestone
Mainnet 1 RC0
Development

Successfully merging a pull request may close this issue.

fix(swingset): fix transcript extract/replay tools Agoric/agoric-sdk
2 participants
@warner @Tartuffo