Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add simpler way to create comms/vattp vats #51

Closed
warner opened this issue Sep 9, 2019 · 2 comments
Closed

add simpler way to create comms/vattp vats #51

warner opened this issue Sep 9, 2019 · 2 comments
Assignees
@Chris-Hibbert
Labels
SwingSet package: SwingSet

Comments

@warner
Copy link
Member

warner commented Sep 9, 2019

We shouldn't have to put stub vat-comms.js or vat-vattp.js files into basedirs to create the comms layer. Instead there should just be some config flag that says "yes I want comms" and it should make the necessary vats (using standardized names so the bootstrap code can wire them up correctly).

It might be nice to wire up the comms and vattp vats automatically too. Doing that will reduce the amount of boilerplate in bootstrap.js, leaving just the initial ingress/egress calls (which we should find a way to simplify too).
@warner warner transferred this issue from Agoric/SwingSet Dec 1, 2019
@warner warner added the SwingSet package: SwingSet label Dec 1, 2019
This was referenced Dec 1, 2019
Open
Closed
dckc pushed a commit to dckc/agoric-sdk that referenced this issue Dec 5, 2019
@michaelfig
Reenable bin/vat
b13a3b4 
Add missing src/devices/index.js with named exports from the devices'
top-halves.

fixes Agoric#51
dckc pushed a commit to dckc/agoric-sdk that referenced this issue Dec 5, 2019
@michaelfig
Merge pull request Agoric#52 from DavidBruant/issue-51
42a2ced 
Issue Agoric#51
@warner
Copy link
Member Author

warner commented Jan 29, 2020

@Chris-Hibbert I think this is done now, please close if you agree

@Chris-Hibbert
Copy link
Contributor

I don't think so. Leaving it open as there's work to do to make creation of these vats happen by default the way we now do with the vatAdmin vat and device.

@warner warner mentioned this issue Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
SwingSet package: SwingSet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@warner @Chris-Hibbert