We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the Problem Being Solved?
Currently, we cannot kickOut multiple seats in one turn because kickOut throws. Instead, it should return an error which we can throw if we wish.
kickOut
Description of the Design
zcfSeat.kickOut should return an error, and should not itself throw.
zcfSeat.kickOut
Security Considerations
We should make sure nothing depended on this functionality.
Test Plan Current tests, also, perhaps adding a test in which multiple seats get kicked out in one turn.
The text was updated successfully, but these errors were encountered:
Since no existing tests were impacted, it would be helpful to add some tests that exercise this both for a single seat and multiple seats.
Sorry, something went wrong.
Yup, will do.
katelynsills
Successfully merging a pull request may close this issue.
What is the Problem Being Solved?
Currently, we cannot
kickOut
multiple seats in one turn becausekickOut
throws. Instead, it should return an error which we can throw if we wish.Description of the Design
zcfSeat.kickOut
should return an error, and should not itself throw.Security Considerations
We should make sure nothing depended on this functionality.
Test Plan
Current tests, also, perhaps adding a test in which multiple seats get kicked out in one turn.
The text was updated successfully, but these errors were encountered: