Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KickOut Should Not Throw #1662

Closed
katelynsills opened this issue Sep 1, 2020 · 2 comments · Fixed by #1663
Closed

KickOut Should Not Throw #1662

katelynsills opened this issue Sep 1, 2020 · 2 comments · Fixed by #1663
Assignees
Labels
Zoe package: Zoe

Comments

@katelynsills
Copy link
Contributor

What is the Problem Being Solved?

Currently, we cannot kickOut multiple seats in one turn because kickOut throws. Instead, it should return an error which we can throw if we wish.

Description of the Design

zcfSeat.kickOut should return an error, and should not itself throw.

Security Considerations

We should make sure nothing depended on this functionality.

Test Plan
Current tests, also, perhaps adding a test in which multiple seats get kicked out in one turn.

@katelynsills katelynsills added the Zoe package: Zoe label Sep 1, 2020
@katelynsills katelynsills self-assigned this Sep 1, 2020
@Chris-Hibbert
Copy link
Contributor

Since no existing tests were impacted, it would be helpful to add some tests that exercise this both for a single seat and multiple seats.

@katelynsills
Copy link
Contributor Author

Since no existing tests were impacted, it would be helpful to add some tests that exercise this both for a single seat and multiple seats.

Yup, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Zoe package: Zoe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants