Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kickOut does not throw itself #1663

Merged
merged 5 commits into from
Sep 2, 2020
Merged

fix: kickOut does not throw itself #1663

merged 5 commits into from
Sep 2, 2020

Conversation

katelynsills
Copy link
Contributor

Closes #1662

@katelynsills katelynsills added the Zoe package: Zoe label Sep 1, 2020
@katelynsills katelynsills self-assigned this Sep 1, 2020
@katelynsills
Copy link
Contributor Author

@Chris-Hibbert test added

michaelfig
michaelfig approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by review. LGTM!

The automatic throw was something I didn't expect when using kickOut, so I'm glad to see it gone.

@katelynsills katelynsills requested a review from erights September 2, 2020 16:46
erights
erights approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Definitely better.

@katelynsills katelynsills merged commit 9985dc4 into master Sep 2, 2020
@katelynsills katelynsills deleted the 1662-kick-out branch September 2, 2020 23:16
@katelynsills katelynsills mentioned this pull request Sep 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris-Hibbert Chris-Hibbert Chris-Hibbert approved these changes

@michaelfig michaelfig michaelfig approved these changes

@erights erights erights approved these changes

Assignees

@katelynsills katelynsills

Labels
Zoe package: Zoe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KickOut Should Not Throw
4 participants
@katelynsills @erights @michaelfig @Chris-Hibbert