Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z:acceptance "user can open a vault under debt limit" is flakey #10599

Closed
0xpatrickdev opened this issue Dec 2, 2024 · 1 comment · Fixed by #10643
Closed

z:acceptance "user can open a vault under debt limit" is flakey #10599

0xpatrickdev opened this issue Dec 2, 2024 · 1 comment · Fixed by #10643
Assignees
Labels
flake flakey test

Comments

@0xpatrickdev
Copy link
Member

What is the Problem Being Solved?

The user can open a vault under debt limit test in a3p-integration/proposals/z:acceptance/vaults.test.js seems to be flaky.

Several PR's that do not touch @agoric/inter-protocol nor @agoric/synthetic-chain are consistently failing with:

 vaults.test.js:243

   242:                                     
   243:   t.is(                             
   244:     istBalanceBefore + Number(mint),

  The IST balance should increase by the minted amount

  Difference (- actual, + expected):

  - 43975819.49
  + 43975819.29

  › file://vaults.test.js:243:5

https://github.com/Agoric/agoric-sdk/actions/runs/12092142628/job/33721506423?pr=10588#step:10:6598
https://github.com/Agoric/agoric-sdk/actions/runs/12092261743/job/33721780758?pr=10571#step:10:6638
https://github.com/Agoric/agoric-sdk/actions/runs/12123427233/job/33798927107?pr=10591#step:10:6534

Description of the Design

  • test.skip should be restored
  • test should consistently pass in CI

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@0xpatrickdev 0xpatrickdev added the flake flakey test label Dec 2, 2024
0xpatrickdev added a commit that referenced this issue Dec 2, 2024
- filed #10599 after observing multiple flakes from unrelated changes
@0xpatrickdev 0xpatrickdev changed the title z:acceptance "user can open a vault under debt limit" is flaky z:acceptance "user can open a vault under debt limit" is flakey Dec 2, 2024
0xpatrickdev added a commit that referenced this issue Dec 2, 2024
- filed #10599 after observing multiple flakes from unrelated changes
0xpatrickdev added a commit that referenced this issue Dec 3, 2024
- filed #10599 after observing multiple flakes from unrelated changes
0xpatrickdev added a commit that referenced this issue Dec 3, 2024
- filed #10599 after observing multiple flakes from unrelated changes
0xpatrickdev added a commit that referenced this issue Dec 3, 2024
- filed #10599 after observing multiple flakes from unrelated changes
@turadg
Copy link
Member

turadg commented Dec 3, 2024

  Error: psmSwap tx send failed: {"exitCode":2}
      at psmSwap (file:///usr/src/proposals/z:acceptance/test-lib/psm-lib.js:552:11)
      at async file:///usr/src/proposals/z:acceptance/psm.test.js:195:3

failure that is passing on retry

Upstream in the logs,

7:00PM ERR Error on broadcastTxCommit err="timed out waiting for tx to be included in a block" module=rpc
psmSwap tx send failed {
  command: 'agoric wallet --keyring-backend=test send --offer /tmp/agops.OlQ --from agoric1zlesuj60a3f59slushj65xx5asmzd8s7mn59qm --verbose',
  durationMs: 11091.834717,
  shortMessage: "Command failed with exit code 2: agoric wallet '--keyring-backend=test' send --offer /tmp/agops.OlQ --from agoric1zlesuj60a3f59slushj65xx5asmzd8s7mn59qm --verbose",
  cause: undefined,
  exitCode: 2,
…
    'Error: error in json rpc client, with http response metadata: (Status: 200 OK, Protocol HTTP/1.1). RPC error -32603 - Internal error: timed out waiting for tx to be included in a block\n' +

anilhelvaci added a commit that referenced this issue Dec 8, 2024
anilhelvaci added a commit that referenced this issue Dec 8, 2024
closes: #10599

fix: remove TODO comment

fix: format fix
@mergify mergify bot closed this as completed in #10643 Dec 9, 2024
@mergify mergify bot closed this as completed in 82447f3 Dec 9, 2024
mergify bot added a commit that referenced this issue Dec 9, 2024
closes: #10599

## Description

#10599 pointed out a flakiness in `z:acceptance/vaults.test.js`. Investigations showed the problem was because of the batched IST fee which is charged for every 10 offers for a given user. We started using `tryISTBalance` instead of a direct assertion. 

### Security Considerations

None.

### Scaling Considerations

Making sure there are no flakiness in `a3p-integration/z:acceptance` tests is important as it  affects other PRs in the CI. This should fix one of the discovered ones.

### Documentation Considerations

None.

### Testing Considerations

This should unblock other PRs CI process. No other considerations.

### Upgrade Considerations

`z:acceptance` tests run before every upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flake flakey test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants