-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
z:acceptance
"user can open a vault under debt limit" is flakey
#10599
Labels
flake
flakey test
Comments
0xpatrickdev
added a commit
that referenced
this issue
Dec 2, 2024
- filed #10599 after observing multiple flakes from unrelated changes
0xpatrickdev
changed the title
Dec 2, 2024
z:acceptance
"user can open a vault under debt limit" is flakyz:acceptance
"user can open a vault under debt limit" is flakey
0xpatrickdev
added a commit
that referenced
this issue
Dec 2, 2024
- filed #10599 after observing multiple flakes from unrelated changes
0xpatrickdev
added a commit
that referenced
this issue
Dec 3, 2024
- filed #10599 after observing multiple flakes from unrelated changes
0xpatrickdev
added a commit
that referenced
this issue
Dec 3, 2024
- filed #10599 after observing multiple flakes from unrelated changes
0xpatrickdev
added a commit
that referenced
this issue
Dec 3, 2024
- filed #10599 after observing multiple flakes from unrelated changes
failure that is passing on retry Upstream in the logs,
|
anilhelvaci
added a commit
that referenced
this issue
Dec 8, 2024
anilhelvaci
added a commit
that referenced
this issue
Dec 8, 2024
closes: #10599 fix: remove TODO comment
anilhelvaci
added a commit
that referenced
this issue
Dec 8, 2024
closes: #10599 fix: remove TODO comment fix: format fix
mergify bot
added a commit
that referenced
this issue
Dec 9, 2024
closes: #10599 ## Description #10599 pointed out a flakiness in `z:acceptance/vaults.test.js`. Investigations showed the problem was because of the batched IST fee which is charged for every 10 offers for a given user. We started using `tryISTBalance` instead of a direct assertion. ### Security Considerations None. ### Scaling Considerations Making sure there are no flakiness in `a3p-integration/z:acceptance` tests is important as it affects other PRs in the CI. This should fix one of the discovered ones. ### Documentation Considerations None. ### Testing Considerations This should unblock other PRs CI process. No other considerations. ### Upgrade Considerations `z:acceptance` tests run before every upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
The
user can open a vault under debt limit
test ina3p-integration/proposals/z:acceptance/vaults.test.js
seems to be flaky.Several PR's that do not touch
@agoric/inter-protocol
nor@agoric/synthetic-chain
are consistently failing with:https://github.com/Agoric/agoric-sdk/actions/runs/12092142628/job/33721506423?pr=10588#step:10:6598
https://github.com/Agoric/agoric-sdk/actions/runs/12092261743/job/33721780758?pr=10571#step:10:6638
https://github.com/Agoric/agoric-sdk/actions/runs/12123427233/job/33798927107?pr=10591#step:10:6534
Description of the Design
test.skip
should be restoredSecurity Considerations
Scaling Considerations
Test Plan
Upgrade Considerations
The text was updated successfully, but these errors were encountered: