Skip to content

Commit

Permalink
fix: review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
@erights
erights committed Feb 28, 2023
1 parent ef35a91 commit fdcf70d
Show file tree
Hide file tree
Showing 9 changed files with 33 additions and 33 deletions.
12 changes: 6 additions & 6 deletions packages/inter-protocol/src/stakeFactory/stakeFactoryKit.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -373,18 +373,18 @@ const potBehavior = {
const AdjustBalancesProposalShape = M.or(
M.splitRecord({
give: {
Attestation: AmountShape, // TODO brand specific AmountShape
Attestation: AmountShape, // TODO get amount shape from brand
},
want: {
Debt: AmountShape, // TODO brand specific AmountShape
Debt: AmountShape, // TODO get amount shape from brand
},
}),
M.splitRecord({
give: {
Debt: AmountShape, // TODO brand specific AmountShape
Debt: AmountShape, // TODO get amount shape from brand
},
want: {
Attestation: AmountShape, // TODO brand specific AmountShape
Attestation: AmountShape, // TODO get amount shape from brand
},
}),
);
Expand All @@ -404,10 +404,10 @@ const potBehavior = {

const CloseProposalShape = M.splitRecord({
give: {
[KW.Debt]: AmountShape, // TODO brand specific AmountShape
[KW.Debt]: AmountShape, // TODO get amount shape from brand
},
want: {
[KW.Attestation]: AmountShape, // TODO brand specific AmountShape
[KW.Attestation]: AmountShape, // TODO get amount shape from brand
},
});

Expand Down
4 changes: 2 additions & 2 deletions packages/inter-protocol/src/vaultFactory/liquidateIncrementally.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -335,10 +335,10 @@ const start = async zcf => {

const LiquidateProposalShape = M.splitRecord({
give: {
In: AmountShape, // TODO brand-specific AmountShape
In: AmountShape, // TODO get amount shape from brand
},
want: {
Out: AmountShape, // TODO brand-specific AmountShape
Out: AmountShape, // TODO get amount shape from brand
},
});

Expand Down
12 changes: 6 additions & 6 deletions packages/inter-protocol/src/vaultFactory/vault.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -182,16 +182,16 @@ export const prepareVault = (baggage, marshaller, zcf) => {
give: M.splitRecord(
{},
{
Collateral: AmountShape, // TODO brand specific AmountShape
Minted: AmountShape, // TODO brand specific AmountShape
Collateral: AmountShape, // TODO get amount shape from brand
Minted: AmountShape, // TODO get amount shape from brand
},
{},
),
want: M.splitRecord(
{},
{
Collateral: AmountShape, // TODO brand specific AmountShape
Minted: AmountShape, // TODO brand specific AmountShape
Collateral: AmountShape, // TODO get amount shape from brand
Minted: AmountShape, // TODO get amount shape from brand
},
{},
),
Expand All @@ -201,14 +201,14 @@ export const prepareVault = (baggage, marshaller, zcf) => {
give: M.splitRecord(
{},
{
Minted: AmountShape, // TODO brand specific AmountShape
Minted: AmountShape, // TODO get amount shape from brand
},
{},
),
want: M.splitRecord(
{},
{
Collateral: AmountShape, // TODO brand specific AmountShape
Collateral: AmountShape, // TODO get amount shape from brand
},
{},
),
Expand Down
4 changes: 2 additions & 2 deletions packages/inter-protocol/src/vaultFactory/vaultManager.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -254,10 +254,10 @@ export const prepareVaultManagerKit = (

const MakeVaultProposalShape = M.splitRecord({
give: {
Collateral: AmountShape, // TODO brand specific AmountShape
Collateral: AmountShape, // TODO get amount shape from brand
},
want: {
Minted: AmountShape, // TODO brand specific AmountShape
Minted: AmountShape, // TODO get amount shape from brand
},
});

Expand Down
12 changes: 6 additions & 6 deletions packages/inter-protocol/src/vpool-xyk-amm/addLiquidity.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ const makeMakeAddLiquidityInvitation = (zcf, getPool) => {

const AddLiquidityProposalShape = M.splitRecord({
give: {
Central: AmountShape, // TODO brand specific AmountShape
Secondary: AmountShape, // TODO brand specific AmountShape
Central: AmountShape, // TODO get amount shape from brand
Secondary: AmountShape, // TODO get amount shape from brand
},
want: {
Liquidity: AmountShape, // TODO brand specific AmountShape
Liquidity: AmountShape, // TODO get amount shape from brand
},
});

Expand Down Expand Up @@ -208,11 +208,11 @@ const makeMakeAddLiquidityAtRateInvitation = (

const AddLiquidityAtProposalShape = M.splitRecord({
give: {
Central: AmountShape, // TODO brand specific AmountShape
Secondary: AmountShape, // TODO brand specific AmountShape
Central: AmountShape, // TODO get amount shape from brand
Secondary: AmountShape, // TODO get amount shape from brand
},
want: {
Liquidity: AmountShape, // TODO brand specific AmountShape
Liquidity: AmountShape, // TODO get amount shape from brand
},
});

Expand Down
6 changes: 3 additions & 3 deletions packages/inter-protocol/src/vpool-xyk-amm/addPool.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -192,13 +192,13 @@ export const makeAddPoolInvitation = (

const AddPoolProposalShape = M.splitRecord({
give: {
Central: AmountShape, // TODO brand specific AmountShape
Secondary: AmountShape, // TODO brand specific AmountShape
Central: AmountShape, // TODO get amount shape from brand
Secondary: AmountShape, // TODO get amount shape from brand
},
want: M.splitRecord(
{},
{
Liquidity: AmountShape, // TODO brand specific AmountShape
Liquidity: AmountShape, // TODO get amount shape from brand
},
{},
),
Expand Down
6 changes: 3 additions & 3 deletions packages/inter-protocol/src/vpool-xyk-amm/removeLiquidity.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ export const makeMakeRemoveLiquidityInvitation = (zcf, getPool) => {

const RemoveLiquidityProposalShape = M.splitRecord({
want: {
Central: AmountShape, // TODO brand specific AmountShape
Secondary: AmountShape, // TODO brand specific AmountShape
Central: AmountShape, // TODO get amount shape from brand
Secondary: AmountShape, // TODO get amount shape from brand
},
give: {
Liquidity: AmountShape, // TODO brand specific AmountShape
Liquidity: AmountShape, // TODO get amount shape from brand
},
});

Expand Down
2 changes: 1 addition & 1 deletion packages/pegasus/src/pegasus.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const DEFAULT_TRANSFER_PROTOCOL = ICS20TransferProtocol;

const TRANSFER_PROPOSAL_SHAPE = M.splitRecord({
give: {
Transfer: AmountShape, // TODO brand specific AmountShape
Transfer: AmountShape, // TODO get amount shape from brand
},
});

Expand Down
8 changes: 4 additions & 4 deletions packages/zoe/src/contracts/auction/index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -117,19 +117,19 @@ const start = zcf => {

const BidProposalShape = M.splitRecord({
give: {
Bid: AmountShape, // TODO brand specific AmountShape
Bid: AmountShape, // TODO get amount shape from brand
},
want: {
Asset: AmountShape, // TODO brand specific AmountShape
Asset: AmountShape, // TODO get amount shape from brand
},
});

const SellProposalShape = M.splitRecord({
give: {
Asset: AmountShape, // TODO brand specific AmountShape
Asset: AmountShape, // TODO get amount shape from brand
},
want: {
Ask: AmountShape, // TODO brand specific AmountShape
Ask: AmountShape, // TODO get amount shape from brand
},
exit: {
// The auction is not over until the deadline according to the
Expand Down

0 comments on commit fdcf70d

Please sign in to comment.