ci: continuing linting when one kind errors (#4416)

* format: prettier .github yml files

* for code quality checks, skip matrix and use the active LTS

* separate types-check from lint-check

* exclude types from lint-fix

* Revert "separate types-check from lint-check"

This reverts commit 7fc4f39.

* single 'yarn lint' for all linting

* single 'yarn lint' for all linting

* remove 'lint-check', redundant with 'lint'

* include Jessie linting

* remove broken lint..jessie commands

* back out CI matrix and formatting change

* use run-s consistently

* fix typo

.github/workflows/test-all-packages.yml

@@ -61,9 +61,7 @@ jobs:
         node-version: ${{ matrix.node-version }}
 
     - name: lint check
-      run: yarn lint-check
-    - name: format check
-      run: yarn format-check
+      run: yarn lint
 
   dev-canary:
     if: ${{github.event_name == 'push'}}

golang/cosmos/package.json

@@ -17,7 +17,7 @@
     "test:xs": "exit 0",
     "build": "exit 0",
     "lint-fix": "eslint --fix '**/*.js'",
-    "lint-check": "eslint '**/*.js'"
+    "lint": "eslint '**/*.js'"
   },
   "dependencies": {
     "bindings": "^1.2.1"

package.json

@@ -61,6 +61,7 @@
     "eslint-plugin-jsx-a11y": "^6.4.0",
     "eslint-plugin-prettier": "^3.2.0",
     "lerna": "^3.20.2",
+    "npm-run-all": "^4.1.5",
     "prettier": "^1.19.1",
     "typescript": "^4.2.3"
   },
@@ -81,10 +82,10 @@
     "link-cli": "yarn run create-agoric-cli",
     "create-agoric-cli": "node ./scripts/create-agoric-cli.cjs",
     "format": "yarn prettier --write 'packages/**/*.{js,jsx,ts,tsx}' 'golang/**/*.{js,jsx,ts,tsx}'",
-    "format-check": "yarn prettier --check 'packages/**/*.{js,jsx,ts,tsx}' 'golang/**/*.{js,jsx,ts,tsx}'",
+    "lint:format": "yarn prettier --check 'packages/**/*.{js,jsx,ts,tsx}' 'golang/**/*.{js,jsx,ts,tsx}'",
     "lint-fix": "yarn workspaces run lint-fix",
-    "lint-check": "yarn workspaces run lint-check",
-    "lint": "yarn workspaces run lint-check",
+    "lint": "run-s --continue-on-error lint:*",
+    "lint:packages": "yarn workspaces run lint",
     "test": "yarn workspaces run test",
     "test:c8-all": "rm -rf coverage/tmp && C8_OPTIONS=\"--clean=false --temp-directory=$PWD/coverage/tmp\" lerna run test:c8",
     "test:xs": "yarn workspaces run test:xs",

packages/ERTP/package.json

@@ -13,9 +13,8 @@
     "test:xs": "yarn test:xs-unit && yarn test:xs-worker",
     "test:xs-unit": "ava-xs",
     "test:xs-worker": "SWINGSET_WORKER_TYPE=xs-worker ava -c 2 'test/swingsetTests/**/test-*.js'",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:eslint": "eslint '**/*.js'",
     "lint:types": "tsc --maxNodeModuleJsDepth 3 -p jsconfig.json"
   },

packages/SwingSet/.circleci/config.yml

@@ -40,7 +40,7 @@ jobs:
           command: npm test
       - run: &lint
           name: Lint
-          command: npm run lint-check
+          command: npm run lint
 
 
   # Automated Npm Audit Fix PR

packages/SwingSet/package.json

@@ -15,8 +15,7 @@
     "test": "ava",
     "test:xs": "SWINGSET_WORKER_TYPE=xs-worker ava",
     "test:xs-worker": "ava test/workers/test-worker.js -m 'xs vat manager'",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
+    "lint-fix": "yarn lint:eslint --fix",
     "lint": "yarn lint:types&&yarn lint:eslint",
     "lint:types": "tsc --maxNodeModuleJsDepth 3 -p jsconfig.json",
     "lint:eslint": "eslint '**/*.js'"

packages/access-token/package.json

@@ -12,7 +12,6 @@
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
-    "lint-check": "yarn lint",
     "lint-fix": "eslint --fix '**/*.js'",
     "lint": "eslint '**/*.js'"
   },

packages/agoric-cli/.circleci/config.yml

@@ -80,7 +80,7 @@ jobs:
       - *save_cache
       - run: &lint
           name: Lint
-          command: npm run lint-check
+          command: npm run lint
       - run: &test
           name: Test
           command: npm test

packages/agoric-cli/package.json

@@ -15,9 +15,8 @@
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
     "integration-test": "ava --config .ava-integration-test.config.js",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:types": "tsc --maxNodeModuleJsDepth 4 -p jsconfig.json",
     "lint:eslint": "eslint '**/*.js'"
   },

packages/assert/package.json

@@ -12,9 +12,8 @@
     "test": "exit 0",
     "test:nyc": "exit 0",
     "test:xs": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:eslint": "eslint '**/*.js'",
     "lint:types": "tsc -p jsconfig.json"
   },

packages/bundle-source/.circleci/config.yml

@@ -80,7 +80,7 @@ jobs:
       - *save_cache
       - run: &lint
           name: Lint
-          command: npm run lint-check
+          command: npm run lint
       - run: &test
           name: Test
           command: npm test

packages/bundle-source/package.json

@@ -10,9 +10,6 @@
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
     "lint-fix": "eslint --fix '**/*.js'",
-    "lint-check": "yarn lint",
-    "lint-fix-jessie": "eslint -c '.eslintrc-jessie.js' --fix '**/*.js'",
-    "lint-check-jessie": "eslint -c '.eslintrc-jessie.js' '**/*.js'",
     "lint": "eslint '**/*.js'"
   },
   "devDependencies": {

packages/cosmic-swingset/package.json

@@ -13,9 +13,8 @@
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:types": "tsc --maxNodeModuleJsDepth 3 -p jsconfig.json",
     "lint:eslint": "eslint '**/*.js'"
   },

packages/deploy-script-support/package.json

@@ -11,11 +11,10 @@
     "build": "exit 0",
     "test": "ava",
     "test:xs": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
+    "lint-fix": "yarn lint:eslint --fix",
     "lint:eslint": "eslint '**/*.js'",
     "lint:types": "tsc --maxNodeModuleJsDepth 5 -p jsconfig.json",
-    "lint": "yarn lint:types && yarn lint:eslint"
+    "lint": "run-s --continue-on-error lint:*"
   },
   "repository": {
     "type": "git",

packages/deployment/package.json

@@ -12,7 +12,6 @@
     "test": "exit 0",
     "test:xs": "exit 0",
     "build": "exit 0",
-    "lint-check": "yarn lint",
     "lint-fix": "eslint --fix '**/*.js'",
     "lint": "eslint '**/*.js'"
   },

packages/eslint-config/package.json

@@ -18,7 +18,6 @@
     "test:nyc": "exit 0",
     "test:xs": "exit 0",
     "build": "exit 0",
-    "lint-check": "exit 0",
     "lint-fix": "exit 0",
     "lint": "exit 0"
   },

packages/eventual-send/.circleci/config.yml

@@ -31,7 +31,7 @@ jobs:
           <<: *save_cache
       - run:
           name: Lint
-          command: npm run lint-check
+          command: npm run lint
       - run:
           name: Test
           command: npm test

packages/eventual-send/package.json

@@ -10,9 +10,8 @@
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
     "build": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:types": "tsc -p jsconfig.json",
     "lint:eslint": "eslint '**/*.js'"
   },

packages/governance/package.json

@@ -12,9 +12,8 @@
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:eslint": "eslint '**/*.js'",
     "lint:types": "tsc --maxNodeModuleJsDepth 3 -p jsconfig.json"
   },

packages/import-bundle/package.json

@@ -13,7 +13,6 @@
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
     "build": "exit 0",
-    "lint-check": "yarn lint",
     "lint-fix": "eslint --fix '**/*.js'",
     "lint": "eslint '**/*.js'"
   },

packages/import-manager/package.json

@@ -13,7 +13,6 @@
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
     "lint-fix": "eslint --fix '**/*.js'",
-    "lint-check": "yarn lint",
     "lint": "eslint '**/*.js'"
   },
   "repository": {

packages/notifier/package.json

@@ -12,9 +12,8 @@
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:eslint": "eslint '**/*.js'",
     "lint:types": "tsc --maxNodeModuleJsDepth 3 -p jsconfig.json"
   },

packages/pegasus/package.json

@@ -13,9 +13,8 @@
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:eslint": "eslint '**/*.js'",
     "lint:types": "tsc --maxNodeModuleJsDepth 4 -p jsconfig.json"
   },

packages/promise-kit/package.json

@@ -11,9 +11,8 @@
     "build": "exit 0",
     "test": "exit 0",
     "test:xs": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:eslint": "eslint '**/*.js'",
     "lint:types": "tsc -p jsconfig.json"
   },

packages/run-protocol/package.json

@@ -13,9 +13,8 @@
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:eslint": "eslint '**/*.js'",
     "lint:types": "tsc --maxNodeModuleJsDepth 5 -p jsconfig.json"
   },

packages/same-structure/package.json

@@ -11,7 +11,6 @@
     "build": "exit 0",
     "test": "exit 0",
     "test:xs": "exit 0",
-    "lint-check": "yarn lint",
     "lint-fix": "eslint --fix '**/*.js'",
     "lint": "eslint '**/*.js'"
   },

packages/sharing-service/package.json

@@ -12,7 +12,6 @@
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
-    "lint-check": "yarn lint",
     "lint-fix": "eslint --fix '**/*.js'",
     "lint": "eslint '**/*.js'"
   },

packages/solo/package.json

@@ -13,9 +13,8 @@
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:types": "tsc --maxNodeModuleJsDepth 4 -p jsconfig.json",
     "lint:eslint": "eslint '**/*.js'"
   },

packages/sparse-ints/package.json

@@ -11,7 +11,6 @@
     "build": "exit 0",
     "test": "exit 0",
     "test:xs": "exit 0",
-    "lint-check": "yarn lint",
     "lint-fix": "eslint --fix '**/*.js'",
     "lint": "eslint '**/*.js'"
   },

packages/spawner/package.json

@@ -13,7 +13,6 @@
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
-    "lint-check": "yarn lint",
     "lint-fix": "eslint --fix '**/*.js'",
     "lint": "eslint '**/*.js'"
   },

packages/stat-logger/package.json

@@ -11,7 +11,6 @@
     "build": "exit 0",
     "test": "exit 0",
     "test:xs": "exit 0",
-    "lint-check": "yarn lint",
     "lint-fix": "eslint --fix '**/*.js'",
     "lint": "eslint '**/*.js'"
   },

packages/store/package.json

@@ -11,9 +11,8 @@
     "build": "exit 0",
     "test": "ava",
     "test:xs": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:types": "tsc --maxNodeModuleJsDepth 3 -p jsconfig.json",
     "lint:eslint": "eslint '**/*.js'"
   },

packages/swing-store/package.json

@@ -12,9 +12,8 @@
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:types": "tsc -p jsconfig.json",
     "lint:eslint": "eslint '**/*.js'"
   },

packages/swingset-runner/package.json

@@ -14,7 +14,6 @@
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
     "lint-fix": "eslint --fix '**/*.js'",
-    "lint-check": "yarn lint",
     "lint": "eslint '**/*.js'",
     "ci:autobench": "./autobench.js"
   },

packages/telemetry/package.json

@@ -10,9 +10,8 @@
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:types": "tsc -p jsconfig.json",
     "lint:eslint": "eslint '**/*.js'"
   },

packages/ui-components/package.json

@@ -26,8 +26,7 @@
     "build:src": "rm -rf dist && BABEL_ENV='test' ./node_modules/.bin/babel src --out-dir dist",
     "build": "yarn build:src && yarn build:tests",
     "lint-fix": "yarn lint --fix",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:eslint": "eslint '**/*.js'",
     "lint:types": "tsc --maxNodeModuleJsDepth 4 -p jsconfig.json"
   },

packages/vats/package.json

@@ -10,9 +10,8 @@
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
-    "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
-    "lint-check": "yarn lint",
-    "lint": "yarn lint:types && yarn lint:eslint",
+    "lint-fix": "yarn lint:eslint --fix",
+    "lint": "run-s --continue-on-error lint:*",
     "lint:types": "tsc --maxNodeModuleJsDepth 4 -p jsconfig.json",
     "lint:eslint": "eslint '**/*.js'"
   },

packages/wallet-connection/package.json

@@ -12,7 +12,6 @@
     "test:c8": "exit 0",
     "test:xs": "exit 0",
     "lint-fix": "exit 0",
-    "lint-check": "exit 0",
     "lint": "exit 0",
     "lint:types": "exit 0",
     "lint:eslint": "exit 0"