fixup to test without a new contract

Agoric · Sep 16, 2024 · d232c8d · d232c8d
1 parent f283047
commit d232c8d
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 117 deletions.
diff --git a/packages/builders/scripts/testing/fix-buggy-sendAnywhere.js b/packages/builders/scripts/testing/fix-buggy-sendAnywhere.js
@@ -17,7 +17,7 @@ import { E } from '@endo/far';
 const trace = makeTracer('StartBuggySA', true);
 
 /**
- * @import {start as StartFn} from '@agoric/orchestration/src/examples/buggy-sendAnywhere.contract.js';
+ * @import {start as StartFn} from '@agoric/orchestration/src/examples/send-anywhere.contract.js';
  */
 
 /**

diff --git a/packages/builders/scripts/testing/start-buggy-sendAnywhere.js b/packages/builders/scripts/testing/start-buggy-sendAnywhere.js
@@ -7,7 +7,7 @@ import {
   makeTracer,
   NonNullish,
 } from '@agoric/internal';
-import { E } from '@endo/far';
+import { E, Far } from '@endo/far';
 
 /// <reference types="@agoric/vats/src/core/types-ambient"/>
 /**
@@ -17,7 +17,7 @@ import { E } from '@endo/far';
 const trace = makeTracer('StartBuggySA', true);
 
 /**
- * @import {start as StartFn} from '@agoric/orchestration/src/examples/buggy-sendAnywhere.contract.js';
+ * @import {start as StartFn} from '@agoric/orchestration/src/examples/send-anywhere.contract.js';
  */
 
 /**
@@ -64,18 +64,30 @@ export const startSendAnywhere = async ({
     }),
   );
 
+  const agoricNamesHangs = Far('agoricNames that hangs', {
+    // ...privateArgs.agoricNames,
+    lookup: async () => {
+      trace('agoricNames.lookup being called that will never resolve');
+      // BUG: this never resolves
+      return new Promise(() => {});
+    },
+  });
+
   const { instance } = await E(startUpgradable)({
     label: 'sendAnywhere',
     installation: sendAnywhere,
-    privateArgs,
+    privateArgs: {
+      ...privateArgs,
+      agoricNames: agoricNamesHangs,
+    },
   });
   produceInstance.resolve(instance);
   trace('done');
 };
 harden(startSendAnywhere);
 
 export const getManifestForValueVow = ({ restoreRef }, { sendAnywhereRef }) => {
-  console.log('sendAnywhereRef', sendAnywhereRef);
+  trace('sendAnywhereRef', sendAnywhereRef);
   return {
     manifest: {
       [startSendAnywhere.name]: {
@@ -113,7 +125,7 @@ export const defaultProposalBuilder = async ({ publishRef, install }) =>
       {
         sendAnywhereRef: publishRef(
           install(
-            '@agoric/orchestration/src/examples/buggy-sendAnywhere.contract.js',
+            '@agoric/orchestration/src/examples/send-anywhere.contract.js',
           ),
         ),
       },

diff --git a/packages/orchestration/src/examples/buggy-sendAnywhere.contract.js b/packages/orchestration/src/examples/buggy-sendAnywhere.contract.js
diff --git a/packages/orchestration/src/examples/send-anywhere.contract.js b/packages/orchestration/src/examples/send-anywhere.contract.js
@@ -29,7 +29,7 @@ harden(SingleAmountRecord);
  * @param {Zone} zone
  * @param {OrchestrationTools} tools
  */
-const contract = async (
+export const contract = async (
   zcf,
   privateArgs,
   zone,
@@ -69,6 +69,7 @@ const contract = async (
 
   return { publicFacet, creatorFacet };
 };
+harden(contract);
 
 export const start = withOrchestration(contract);
 harden(start);
-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,7 @@ import { E } from '@endo/far'; @@
     const trace = makeTracer('StartBuggySA', true);
     /**
-     * @import {start as StartFn} from '@agoric/orchestration/src/examples/buggy-sendAnywhere.contract.js';
+     * @import {start as StartFn} from '@agoric/orchestration/src/examples/send-anywhere.contract.js';
      */
     /**
@@ Expand Down @@