lint: remove remaining no-use-before-define

Agoric · Nov 20, 2024 · b05fc01 · b05fc01
1 parent 70e02e7
commit b05fc01
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 8 deletions.
diff --git a/packages/internal/src/node/fs-stream.js b/packages/internal/src/node/fs-stream.js
@@ -21,13 +21,13 @@ export const fsStreamReady = stream =>
     }
 
     const onReady = () => {
-      cleanup(); // eslint-disable-line no-use-before-define
+      cleanup();
       resolve();
     };
 
     /** @param {Error} err */
     const onError = err => {
-      cleanup(); // eslint-disable-line no-use-before-define
+      cleanup();
       reject(err);
     };
 

diff --git a/packages/orchestration/src/examples/staking-combinations.contract.js b/packages/orchestration/src/examples/staking-combinations.contract.js
@@ -75,7 +75,6 @@ const contract = async (
            * @param {{ validator: CosmosValidatorAddress }} offerArgs
            */
           (seat, { validator }) =>
-            // eslint-disable-next-line no-use-before-define -- defined by orchestrateAll, necessarily after this
             orchFns.depositAndDelegate(account, seat, validator),
           'Deposit and delegate',
           undefined,
@@ -98,7 +97,6 @@ const contract = async (
 
         return zcf.makeInvitation(
           () =>
-            // eslint-disable-next-line no-use-before-define -- defined by orchestrateAll, necessarily after this
             orchFns.undelegateAndTransfer(account, {
               delegations,
               destination,

diff --git a/packages/orchestration/src/exos/chain-hub.js b/packages/orchestration/src/exos/chain-hub.js
@@ -283,7 +283,6 @@ export const makeChainHub = (zone, agoricNames, vowTools) => {
     },
   );
 
-  /* eslint-disable no-use-before-define -- chainHub defined below */
   const lookupChainsAndConnection = vowTools.retryable(
     zone,
     'lookupChainsAndConnection',

diff --git a/packages/swingset-liveslots/src/virtualObjectManager.js b/packages/swingset-liveslots/src/virtualObjectManager.js
@@ -1,5 +1,5 @@
 /* global globalThis */
-/* eslint-disable no-use-before-define, jsdoc/require-returns-type */
+/* eslint-disable jsdoc/require-returns-type */
 
 import { environmentOptionsListHas } from '@endo/env-options';
 import { assert, Fail, q, b } from '@endo/errors';

diff --git a/packages/swingset-liveslots/src/virtualReferences.js b/packages/swingset-liveslots/src/virtualReferences.js
@@ -1,4 +1,4 @@
-/* eslint-disable no-use-before-define, jsdoc/require-returns-type */
+/* eslint-disable jsdoc/require-returns-type */
 
 import { assert, Fail } from '@endo/errors';
 import { Nat } from '@endo/nat';

diff --git a/packages/xsnap-lockdown/lib/object-inspect.js b/packages/xsnap-lockdown/lib/object-inspect.js
@@ -1,5 +1,5 @@
 // @ts-nocheck
-/* eslint-disable no-nested-ternary,no-use-before-define */
+/* eslint-disable no-nested-ternary */
 
 /* global globalThis */
 // Adapted from [email protected] https://github.com/inspect-js/object-inspect
-Original file line number
+Diff line change
@@ Expand Up @@
         },
       );
-      /* eslint-disable no-use-before-define -- chainHub defined below */
       const lookupChainsAndConnection = vowTools.retryable(
         zone,
         'lookupChainsAndConnection',
@@ Expand Down @@