Merge pull request #5712 from Agoric/safe-attestation-check

fix(wallet-api): dont rely on attestation brand
Agoric · Jul 1, 2022 · 9ed4278 · 9ed4278
2 parents cafa284 + 447380a
commit 9ed4278
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/packages/wallet/api/src/lib-wallet.js b/packages/wallet/api/src/lib-wallet.js
@@ -580,8 +580,6 @@ export function makeWallet({
     E(agoricNames)?.lookup('issuer', 'Attestation'),
   );
 
-  const getAttBrand = makeMemoizedGetter(() => E(getAttIssuer()).getBrand());
-
   /** @type import('@endo/promise-kit').PromiseKit<AttestationTool> */
   const attMakerPK = makePromiseKit();
 
@@ -670,9 +668,9 @@ export function makeWallet({
         keywordPaymentPs.map(async keywordPaymentP => {
           // Wait for the withdrawal to complete.  This protects against a race
           // when updating paymentToPurse.
-          const [_keyword, payment] = await keywordPaymentP;
+          const [keyword, payment] = await keywordPaymentP;
 
-          if ((await E(payment).getAllegedBrand()) === (await getAttBrand())) {
+          if (keywordToAttestation.has(keyword)) {
             return depositAttestation(payment);
           }
 

diff --git a/packages/wallet/api/test/test-lib-wallet.js b/packages/wallet/api/test/test-lib-wallet.js
@@ -1011,7 +1011,7 @@ test('lib-wallet offer methods', async (/** @type {LibWalletTestContext} */ t) =
           description: 'getRefund',
           handle: {
             kind: 'unnamed',
-            petname: 'unnamed-6',
+            petname: 'unnamed-7',
           },
           installation: {
             kind: 'unnamed',
@@ -1024,7 +1024,7 @@ test('lib-wallet offer methods', async (/** @type {LibWalletTestContext} */ t) =
         },
         inviteHandleBoardId: 'board0257',
         meta: {
-          id: 8,
+          id: 9,
         },
         proposalTemplate: {
           give: { Contribution: { pursePetname: 'Fun budget', value: 1 } },