lint: remove obsolete suppressions

packages/ERTP/src/paymentLedger.js

@@ -1,6 +1,5 @@
 // @jessie-check
 
-/* eslint-disable no-use-before-define */
 import { isPromise } from '@endo/promise-kit';
 import { mustMatch, M, keyEQ } from '@agoric/store';
 import { AmountMath } from './amountMath.js';

packages/SwingSet/src/controller/initializeKernel.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-use-before-define */
-
 import { makeMarshal } from '@endo/marshal';
 import { Far } from '@endo/far';
 import { assert, Fail } from '@agoric/assert';

packages/SwingSet/src/devices/lib/deviceTools.js

@@ -24,7 +24,6 @@ export function buildSerializationTools(syscall, deviceName) {
       send(method, args) {
         assert.typeof(method, 'string');
         assert(Array.isArray(args), args);
-        // eslint-disable-next-line no-use-before-define
         const capdata = serialize([method, args]);
         syscall.sendOnly(slot, capdata);
       },

packages/SwingSet/src/kernel/kernel.js

@@ -989,7 +989,6 @@ export default function buildKernel(
     } else if (message.type === 'changeVatOptions') {
       // prettier-ignore
       return `changeVatOptions ${message.vatID} options: ${JSON.stringify(message.options)}`;
-      // eslint-disable-next-line no-use-before-define
     } else if (gcMessages.includes(message.type)) {
       // prettier-ignore
       return `${message.type} ${message.vatID} ${message.krefs.map(e=>`@${e}`).join(' ')}`;

packages/SwingSet/src/kernel/state/kernelKeeper.js

@@ -764,7 +764,6 @@ export default function makeKernelKeeper(kernelStorage, kernelSlog) {
 
     let idx = 0;
     for (const dataSlot of capdata.slots) {
-      // eslint-disable-next-line no-use-before-define
       incrementRefCount(dataSlot, `resolve|${kernelSlot}|s${idx}`);
       idx += 1;
     }
@@ -787,7 +786,6 @@ export default function makeKernelKeeper(kernelStorage, kernelSlog) {
 
   function cleanupAfterTerminatedVat(vatID) {
     insistVatID(vatID);
-    // eslint-disable-next-line no-use-before-define
     const vatKeeper = provideVatKeeper(vatID);
     const exportPrefix = `${vatID}.c.o+`;
     const importPrefix = `${vatID}.c.o-`;
@@ -1262,7 +1260,6 @@ export default function makeKernelKeeper(kernelStorage, kernelSlog) {
           if (reachable === 0) {
             const ownerVatID = ownerOfKernelObject(kref);
             if (ownerVatID) {
-              // eslint-disable-next-line no-use-before-define
               const vatKeeper = provideVatKeeper(ownerVatID);
               const isReachable = vatKeeper.getReachableFlag(kref);
               if (isReachable) {

packages/SwingSet/src/kernel/vat-warehouse.js

@@ -389,7 +389,6 @@ export function makeVatWarehouse({
     //   entriesReplayed, // retval of replayTranscript() above
     // );
     ephemeral.vats.set(vatID, result);
-    // eslint-disable-next-line no-use-before-define
     await applyAvailabilityPolicy(vatID);
     return result;
   }
@@ -592,7 +591,6 @@ export function makeVatWarehouse({
     //
     /** @type { KernelDeliveryObject } */
     const kd = harden(['bringOutYourDead']);
-    // eslint-disable-next-line no-use-before-define
     const vd = kernelDeliveryToVatDelivery(vatID, kd);
     const vs = kernelSlog.provideVatSlogger(vatID).vatSlog;
     await deliverToVat(vatID, kd, vd, vs);

packages/SwingSet/src/vats/comms/delivery.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-use-before-define */
-
 import { assert, Fail } from '@agoric/assert';
 import { kser } from '@agoric/kmarshal';
 import { parseLocalSlot, insistLocalType } from './parseLocalSlots.js';

packages/SwingSet/src/vats/comms/state.js

@@ -150,7 +150,6 @@ export function makeState(syscall) {
       store.set('r.nextID', '1');
       store.set('initialized', 'true');
       if (controller) {
-        // eslint-disable-next-line no-use-before-define
         addMetaObject(controller);
         cdebug(`comms controller is ${controller}`);
       }
@@ -393,7 +392,6 @@ export function makeState(syscall) {
             // the object is unreachable
 
             const { owner, isReachable, isRecognizable } =
-              // eslint-disable-next-line no-use-before-define
               getOwnerAndStatus(lref);
             if (isReachable) {
               // but the exporter doesn't realize it yet, so schedule a
@@ -558,7 +556,6 @@ export function makeState(syscall) {
       isReachable = isReachableByKernel(lref);
       isRecognizable = !!mapToKernel(lref);
     } else {
-      // eslint-disable-next-line no-use-before-define
       const remote = getRemote(owner);
       isReachable = remote.isReachable(lref);
       isRecognizable = !!remote.mapToRemote(lref);
@@ -794,7 +791,6 @@ export function makeState(syscall) {
     insistPromiseIsUnresolved,
     markPromiseAsResolved,
 
-    // eslint-disable-next-line no-use-before-define
     getRemote,
     addRemote,
     getRemoteIDForName,

packages/SwingSet/src/vats/timer/vat-timer.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-use-before-define */
-
 import { Far, E, passStyleOf } from '@endo/far';
 import { makePromiseKit } from '@endo/promise-kit';
 import { Nat } from '@endo/nat';

packages/SwingSet/src/vats/vat-admin/vat-vat-admin.js

@@ -84,7 +84,6 @@ export function buildRootObject(vatPowers, _vatParameters, baggage) {
       // getNotifier: ({ state }) => state.notifier, // XXX RESTORE
       getNotifier: ({ _self }) => Fail`not implemented, see #7234`, // XXX TEMP
     },
-    // eslint-disable-next-line no-use-before-define
     { finish: finishMeter },
   );
 
@@ -104,18 +103,15 @@ export function buildRootObject(vatPowers, _vatParameters, baggage) {
       // getNotifier: ({ state }) => state.notifier, // will never fire // XXX RESTORE
       getNotifier: ({ _self }) => Fail`not implemented, see #7234`, // XXX TEMP
     },
-    // eslint-disable-next-line no-use-before-define
     { finish: finishMeter },
   );
 
   function finishMeter({ state, self }) {
-    // eslint-disable-next-line no-use-before-define
     meterByID.init(
       state.meterID,
       // harden({ meter: self, updater: state.updater }), // XXX RESTORE
       harden({ meter: self }), // XXX TEMP
     );
-    // eslint-disable-next-line no-use-before-define
     meterIDByMeter.set(self, state.meterID);
   }
 

packages/SwingSet/tools/baggage-check.js

@@ -1,8 +1,6 @@
 import { makeMarshal } from '@endo/marshal';
 import { Far } from '@endo/far';
 
-/* eslint-disable no-use-before-define */
-
 function fakeSTV(slot, iface = 'Remotable') {
   return Far(iface, {
     getSlot: () => slot,

packages/SwingSet/tools/bootstrap-dvo-test.js

@@ -11,7 +11,6 @@ export function buildRootObject() {
   async function runTests(phase) {
     testLog = [];
     doneP = makePromiseKit();
-    // eslint-disable-next-line no-use-before-define
     await E(testVatRoot).runTests(self, phase);
     await doneP.promise;
     return testLog;

packages/agoric-cli/src/install.js

@@ -132,7 +132,6 @@ export default async function installMain(progname, rawArgs, powers, opts) {
         // Ensure we update the package.json before exiting.
         const updatePackageJson = async () => {
           // Don't update on exit anymore.
-          // eslint-disable-next-line no-use-before-define
           process.off('beforeExit', updatePackageJsonOnExit);
           log.info(`updating ${pjson}`);
           await fs.writeFile(

packages/casting/src/leader.js

@@ -31,7 +31,6 @@ export const makeRoundRobinLeader = (endpoints, leaderOptions = {}) => {
       }
       throw err;
     },
-    // eslint-disable-next-line no-use-before-define
     watchCasting: _castingSpecP => pollingChangeFollower,
     /**
      * @template T
@@ -55,10 +54,7 @@ export const makeRoundRobinLeader = (endpoints, leaderOptions = {}) => {
               });
           }
 
-          retrying
-            .then(() => jitter && jitter(where))
-            // eslint-disable-next-line no-use-before-define
-            .then(applyOne, reject);
+          retrying.then(() => jitter && jitter(where)).then(applyOne, reject);
           thisAttempt += 1;
         };
 

packages/cosmic-swingset/src/chain-main.js

@@ -179,7 +179,6 @@ export default async function main(progname, args, { env, homedir, agcc }) {
 
   // Actually run the main ag-chain-cosmos program.  Before we start the daemon,
   // there will be a call to nodePort/AG_COSMOS_INIT, otherwise exit.
-  // eslint-disable-next-line no-use-before-define
   const nodePort = registerPortHandler(toSwingSet);
 
   // Need to keep the process alive until Go exits.

packages/cosmic-swingset/src/sim-chain.js

@@ -173,7 +173,6 @@ export async function connectToFakeChain(basedir, GCI, delay, inbound) {
       await blockingSend({ type: 'COMMIT_BLOCK', blockHeight, blockTime });
 
       clearTimeout(nextBlockTimeout);
-      // eslint-disable-next-line no-use-before-define
       nextBlockTimeout = setTimeout(simulateBlock, maximumDelay);
 
       // TODO: maybe add latency to the inbound messages.

packages/governance/src/contractGovernance/paramManager.js

@@ -122,7 +122,6 @@ const makeParamManagerBuilder = (publisherKit, zoe) => {
     });
 
     // names are keywords so they will necessarily be TitleCase
-    // eslint-disable-next-line no-use-before-define
     getters[`get${name}`] = () => getTypedParam(type, name);
     // CRUCIAL: here we're creating the update functions that can change the
     // values of the governed contract's parameters. We'll return the updateFns
@@ -294,7 +293,6 @@ const makeParamManagerBuilder = (publisherKit, zoe) => {
       getVisibleValue,
     });
 
-    // eslint-disable-next-line no-use-before-define
     getters[`get${name}`] = () => getTypedParam(ParamTypes.INVITATION, name);
     // CRUCIAL: here we're creating the update functions that can change the
     // values of the governed contract's parameters. We'll return updateParams

packages/inter-protocol/src/auction/auctioneer.js

@@ -588,7 +588,6 @@ export const start = async (zcf, privateArgs, baggage) => {
     },
   });
 
-  // eslint-disable-next-line no-use-before-define
   const isActive = () => scheduler.getAuctionState() === AuctionState.ACTIVE;
 
   /**
@@ -655,7 +654,6 @@ export const start = async (zcf, privateArgs, baggage) => {
         );
       },
       getSchedules() {
-        // eslint-disable-next-line no-use-before-define
         return scheduler.getSchedule();
       },
       getScheduleUpdates() {

packages/inter-protocol/src/auction/scheduler.js

@@ -245,7 +245,6 @@ export const makeScheduler = async (
           try {
             setTimeMonotonically(time);
             auctionDriver.capturePrices();
-            // eslint-disable-next-line no-use-before-define
             return startAuction();
           } catch (e) {
             console.error(`⚠️ Auction threw ${e}. Caught in SchedulerWaker.`);

packages/internal/src/node/fs-stream.js

@@ -18,13 +18,13 @@ export const fsStreamReady = stream =>
     }
 
     const onReady = () => {
-      cleanup(); // eslint-disable-line no-use-before-define
+      cleanup();
       resolve();
     };
 
     /** @param {Error} err */
     const onError = err => {
-      cleanup(); // eslint-disable-line no-use-before-define
+      cleanup();
       reject(err);
     };
 

packages/internal/src/node/shutdown.js

@@ -22,7 +22,6 @@ export const makeFreshShutdown = (verbose = true) => {
     process.off('SIGINT', shutdown);
     process.off('SIGTERM', shutdown);
     process.off('beforeExit', shutdown);
-    // eslint-disable-next-line no-use-before-define
     process.off('uncaughtException', uncaughtShutdown);
     verbose && console.error(`Shutting down cleanly...`);
     const shutdowners = [...shutdownThunks.keys()];

packages/notifier/test/map-unum.js

@@ -23,7 +23,6 @@ export const makeMapLeader = initialEntries => {
 
   const change = delta => {
     if (deltaCount >= m.size) {
-      // eslint-disable-next-line no-use-before-define
       snapshot();
     } else {
       deltaPublication.updateState(delta);

packages/orchestration/src/orchestration-api.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-use-before-define */
 /**
  * @file General API of orchestration
  * - must not have chain-specific types without runtime narrowing by chain id

packages/pegasus/src/pegasus.js

@@ -365,7 +365,6 @@ export const makePegasus = ({ zcf, board, namesByAddress, when }) => {
             receiveDenomPublication,
             remoteDenomSubscription,
             abort: reason => {
-              // eslint-disable-next-line no-use-before-define
               actions.abort(reason);
             },
           };

packages/solo/src/chain-cosmos-sdk.js

@@ -696,14 +696,12 @@ ${chainID} chain does not yet know of address ${clientAddr}${adviseEgress(
             .then(txResult => {
               // The result had an error code (not 0 or undefined for success).
               if (txResult.code) {
-                // eslint-disable-next-line no-use-before-define
                 failedSend(
                   assert.error(`Error in tx processing: ${txResult.log}`),
                 );
               }
             })
             .catch(err =>
-              // eslint-disable-next-line no-use-before-define
               failedSend(assert.error(`Error in tx processing: ${err}`)),
             );
 

packages/solo/src/start.js

@@ -118,7 +118,6 @@ const buildSwingset = async (
   const withInputQueue = makeWithQueue();
   const queueThunkForKernel = withInputQueue(async thunk => {
     thunk();
-    // eslint-disable-next-line no-use-before-define
     await processKernel();
   });
 

packages/solo/src/vat-http.js

@@ -27,7 +27,6 @@ export function buildRootObject(vatPowers) {
 
   const lookup = async (...path) => {
     // Take a snapshot of the current home.
-    // eslint-disable-next-line no-use-before-define
     const root = replObjects.home;
 
     if (path.length === 1 && Array.isArray(path[0])) {

packages/solo/src/web.js

@@ -370,7 +370,6 @@ export async function makeHTTPListener(
           return;
         }
 
-        // eslint-disable-next-line no-use-before-define
         sendJSON({ ...res, meta });
       } catch (error) {
         inboundCommand(

packages/swing-store/src/hasher.js

@@ -16,7 +16,6 @@ import { createHash } from 'crypto';
 function createSHA256(initial = undefined) {
   const hash = createHash('sha256');
   let done = false;
-  // eslint-disable-next-line no-use-before-define
   const self = harden({ add, finish, sample });
   function add(more) {
     !done || Fail`hash already finished`;