Skip to content

Commit

Permalink
ci: retry test failing for getting started integration tests (#9740)
Browse files Browse the repository at this point in the history
closes: #9325

## Description

This PR fixes the issue with the integration (link-cli/yarn) job where on a retry of the step (due to the `nick-fields/retry` github action), the step fails because of a `file already exists` error.

The error occurs because we create an `bin/agoric` file in the previous run and on the retry it tries to recreate the file which already exists.

This is done by removing the `bin/agoric` file before the next retry occurs 


Here is a test run for this PR where the job (link-cli/yarn) failed. The CI job repeats without any issues.
https://github.com/Agoric/agoric-sdk/actions/runs/10036266195/job/27733694026?pr=9740

### Security Considerations


### Scaling Considerations


### Documentation Considerations


### Testing Considerations


### Upgrade Considerations
  • Loading branch information
mergify[bot] authored Jul 22, 2024
2 parents ee2126b + 0b1bf64 commit 173e1d8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ jobs:
# won't increase the time for this workflow to complete.
timeout_minutes: 20
command: scripts/registry.sh test ${{ matrix.cli }} ${{steps.get-branch.outputs.result}}
on_retry_command: rm $HOME/bin/agoric

- name: notify on failure
if: >
Expand Down
2 changes: 0 additions & 2 deletions scripts/registry.sh
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ integrationTest() {
# Install the Agoric CLI on this machine's $PATH.
case $1 in
link-cli | link-cli/*)
# Prevent retries from failing with "must not already exist"
rm -f "$HOME/bin/agoric"
yarn link-cli "$HOME/bin/agoric"
persistVar AGORIC_CMD "[\"$HOME/bin/agoric\"]"
;;
Expand Down

0 comments on commit 173e1d8

Please sign in to comment.