Skip to content

Commit

Permalink
chore: respond to review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris-Hibbert committed Sep 14, 2020
1 parent cdfc5e6 commit 12f5911
Showing 1 changed file with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -378,12 +378,16 @@ const makeMockZcfSeatAdmin = (proposal, initialAllocation, getAmountMath) => {
{ proposal, initialAllocation },
getAmountMath,
);
let hasExited = false;
const mockSeat = harden({
isOfferSafe: actual.isOfferSafe,
getCurrentAllocation: actual.getCurrentAllocation,
getProposal: () => proposal,
stage: actual.stage,
hasExited: actual.hasExited,
hasExited: () => hasExited,
exit: () => {
hasExited = true;
},
});
return mockSeat;
};
Expand Down Expand Up @@ -444,6 +448,8 @@ test('ZoeHelpers trade ok', t => {
{ Items: moola(7), Money: simoleans(2) },
'right gets what he wants',
);
t.not(leftZcfSeat.hasExited(), 'Trade should not cause seats to exit');
t.not(rightZcfSeat.hasExited(), 'Trade should not cause seats to exit');
});

test('ZoeHelpers trade same seat', t => {
Expand Down Expand Up @@ -483,4 +489,5 @@ test('ZoeHelpers trade same seat', t => {
{ message: 'a seat cannot trade with itself' },
'seats must be different',
);
t.not(leftZcfSeat.hasExited(), 'Trade should not cause seats to exit');
});

0 comments on commit 12f5911

Please sign in to comment.