Fixes to endowment safety example #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried evaluating the example in the docs and found it was missing a few calls, and replacing the `toString` of `Function.prototype` rather than `Object.prototype`.
katelynsills
reviewed
Apr 1, 2019
docs/api.md
Outdated
| @@ -76,7 +76,7 @@ function makeConsole() { | |||
| } | |||
|
|
|||
| const newConsole = s.evaluate(`(${makeConsole})`, {consoleEndowment: console}); | |||
There was a problem hiding this comment.
Good catch! Do we want to do const newConsole = s.evaluate((${makeConsole}()), {consoleEndowment: console}); instead of calling newConsole?
There was a problem hiding this comment.
Good call, your way is a little more clear. I'll update the PR 👍
warner
added a commit
that referenced
this pull request
Apr 6, 2019
* whitelist Symbol.matchAll, to fix Chrome-v73 (Issue #90) * change primary export #88 * improve documentation #66 #67 * add integration tests #85 * packaging: remove ses-shim.js, add other generated bundles * update Realms shim to commit 0c00eb, to fix Browserify #79 * test against node v10/v11, switch from travis to circleci #73 * fix examples #102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried evaluating the example in the docs and found it was missing a few calls, and replacing the
toStringofFunction.prototyperather thanObject.prototype.